Bug 79650 - [BlackBerry] Credential backing store implementation
Summary: [BlackBerry] Credential backing store implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
URL:
Keywords:
Depends on:
Blocks: 80107
  Show dependency tree / graph
 
Reported: 2012-02-27 02:10 PST by Jonathan Dong
Modified: 2013-01-04 09:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (25.61 KB, patch)
2012-02-27 02:28 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (212.44 KB, patch)
2012-02-27 02:37 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (25.63 KB, patch)
2012-02-27 02:45 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (26.92 KB, patch)
2012-03-01 00:07 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (26.91 KB, patch)
2012-03-02 00:13 PST, Jonathan Dong 		tonikitoo: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff
patch for cq (27.24 KB, patch)
2012-03-04 17:35 PST, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-02-27 02:10:14 PST 
add never_remember table to store the never remember sites; change login update statement to deal with some special case like www.bing.com which would use different url when user changed credential informations; and fix some implementing bugs.
Comment 1 Jonathan Dong 2012-02-27 02:28:53 PST 
Created attachment 128994 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-27 02:31:48 PST 
Attachment 128994 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jonathan Dong 2012-02-27 02:37:43 PST 
Created attachment 128999 [details]
Patch
Comment 4 Jonathan Dong 2012-02-27 02:45:16 PST 
Created attachment 129000 [details]
Patch
Comment 5 Jonathan Dong 2012-03-01 00:07:19 PST 
Created attachment 129649 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-01 00:10:47 PST 
Attachment 129649 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 115 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jonathan Dong 2012-03-02 00:13:04 PST 
Created attachment 129831 [details]
Patch
Comment 8 Antonio Gomes 2012-03-04 10:11:56 PST 
Comment on attachment 129831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129831&action=review

> Source/WebCore/ChangeLog:13
> +        Added never_remember table to store the never remember
> +        sites; changed login update and has statement to support
> +        autofill feature of multiple credential forms in the
> +        same page.
> +
> +        No new tests.

Patch does much more than what you are stating here. Please update before landing.
Comment 9 Jonathan Dong 2012-03-04 17:35:20 PST 
Created attachment 130036 [details]
patch for cq
Comment 10 WebKit Review Bot 2012-03-04 19:24:14 PST 
Comment on attachment 130036 [details]
patch for cq

Clearing flags on attachment: 130036

Committed r109697: <http://trac.webkit.org/changeset/109697>
Comment 11 Eric Seidel (no email) 2013-01-04 00:50:54 PST 
Attachment 129831 [details] was posted by a committer and has review+, assigning to Jonathan Dong for commit.
Comment 12 Rob Buis 2013-01-04 09:29:05 PST 
This was landed in r109697, closing.