Bug 79646 - [EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action
Summary: [EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-02-27 01:34 PST by Grzegorz Czajkowski
Modified: 2012-03-02 00:34 PST (History)
6 users (show)

See Also:

proposed patch (10.57 KB, patch)
2012-02-27 01:36 PST, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2012-02-27 01:34:53 PST
INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction with Ewk_Context_Menu_Action.

To avoid similar case in the feature I added checks between WebCore and  WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
Comment 1 Grzegorz Czajkowski 2012-02-27 01:36:01 PST
Created attachment 128984 [details]
proposed patch
Comment 2 Grzegorz Czajkowski 2012-02-27 03:54:10 PST
CC'ing Ryuan and Michał.
Comment 3 Andreas Kling 2012-03-01 06:51:24 PST
Comment on attachment 128984 [details]
proposed patch

Comment 4 WebKit Review Bot 2012-03-02 00:34:11 PST
Comment on attachment 128984 [details]
proposed patch

Clearing flags on attachment: 128984

Committed r109524: <http://trac.webkit.org/changeset/109524>
Comment 5 WebKit Review Bot 2012-03-02 00:34:16 PST
All reviewed patches have been landed.  Closing bug.