Bug 79641 - [Refactoring] RenderSummary and RenderDetail is no longer needed.
Summary: [Refactoring] RenderSummary and RenderDetail is no longer needed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 00:52 PST by Hajime Morrita
Modified: 2012-02-28 22:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (424.59 KB, patch)
2012-02-27 23:30 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (424.55 KB, patch)
2012-02-28 00:10 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (431.91 KB, patch)
2012-02-28 01:43 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (433.51 KB, patch)
2012-02-28 17:26 PST, Hajime Morrita
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-02-27 00:52:26 PST
Since we reimplemented these in terms of shadow DOM, we no longer need these.
Comment 1 Hajime Morrita 2012-02-27 23:30:41 PST
Created attachment 129196 [details]
Patch
Comment 2 Hajime Morrita 2012-02-27 23:31:36 PST
Kent-san, could you take a look? They're finally gone.
Comment 3 Kent Tamura 2012-02-27 23:54:06 PST
Comment on attachment 129196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129196&action=review

> Source/WebCore/rendering/RenderDetailsMarker.cpp:147
> +    ASSERT(false);

Does this mean ASSERT_NOT_REACHED()?
Comment 4 Hajime Morrita 2012-02-28 00:00:57 PST
> Does this mean ASSERT_NOT_REACHED()?
Oops. It's for debug. I should remove it.
Comment 5 Hajime Morrita 2012-02-28 00:10:46 PST
Created attachment 129202 [details]
Patch
Comment 6 Kent Tamura 2012-02-28 01:02:34 PST
Comment on attachment 129202 [details]
Patch

Looks ok
Comment 7 Hajime Morrita 2012-02-28 01:43:52 PST
Created attachment 129215 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-02-28 03:41:20 PST
Comment on attachment 129215 [details]
Patch for landing

Rejecting attachment 129215 [details] from commit-queue.

New failing tests:
fullscreen/full-screen-render-inline.html
Full output: http://queues.webkit.org/results/11666064
Comment 9 Hajime Morrita 2012-02-28 17:26:25 PST
Created attachment 129360 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-02-28 18:36:13 PST
Comment on attachment 129360 [details]
Patch for landing

Rejecting attachment 129360 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10840 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 10840.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11682071
Comment 11 Hajime Morrita 2012-02-28 22:27:03 PST
Committed r109192: <http://trac.webkit.org/changeset/109192>