Bug 79629 - Color input type should be clickable through keyboard
Summary: Color input type should be clickable through keyboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 23:10 PST by Keishi Hattori
Modified: 2012-02-27 02:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (24.43 KB, patch)
2012-02-26 23:20 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (24.78 KB, patch)
2012-02-26 23:50 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-02-26 23:10:09 PST 
Pressing space/return keys should trigger a click on a focused color input element.
Comment 1 Keishi Hattori 2012-02-26 23:20:12 PST 
Created attachment 128963 [details]
Patch
Comment 2 Kent Tamura 2012-02-26 23:36:04 PST 
Comment on attachment 128963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128963&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp

Please summarize the code change.
e.g. Introduce BaseClickableWithKeyInputType, and ColorInputType inherits it because ....

> Source/WebCore/html/BaseClickableWithKeyInputType.cpp:3
> + * Copyright (C) 2012 Google Inc. All rights reserved.
> + *

This file contains the code of BaseButtonInpuType.cpp.  You have to respect the copyright notice of the original BaseButtonInputType.cpp.
Comment 3 Keishi Hattori 2012-02-26 23:50:12 PST 
Created attachment 128969 [details]
Patch
Comment 4 Keishi Hattori 2012-02-26 23:51:01 PST 
Comment on attachment 128963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128963&action=review

>> Source/WebCore/ChangeLog:8
>> +        * CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
> 
> Please summarize the code change.
> e.g. Introduce BaseClickableWithKeyInputType, and ColorInputType inherits it because ....

Done.

>> Source/WebCore/html/BaseClickableWithKeyInputType.cpp:3
>> + *
> 
> This file contains the code of BaseButtonInpuType.cpp.  You have to respect the copyright notice of the original BaseButtonInputType.cpp.

Done.
Comment 5 Kent Tamura 2012-02-26 23:56:40 PST 
Comment on attachment 128969 [details]
Patch

ok
Comment 6 WebKit Review Bot 2012-02-27 02:23:40 PST 
Comment on attachment 128969 [details]
Patch

Clearing flags on attachment: 128969

Committed r108976: <http://trac.webkit.org/changeset/108976>
Comment 7 WebKit Review Bot 2012-02-27 02:23:44 PST 
All reviewed patches have been landed.  Closing bug.