Bug 79624 - Extract Supplementable base class from Page and Navigator
Summary: Extract Supplementable base class from Page and Navigator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-02-26 22:07 PST by Adam Barth
Modified: 2012-02-26 22:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (52.97 KB, patch)
2012-02-26 22:08 PST, Adam Barth 		morrita: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-26 22:07:28 PST 
Extract Supplementable base class from Page and Navigator
Comment 1 Adam Barth 2012-02-26 22:08:40 PST 
Created attachment 128951 [details]
Patch
Comment 2 Hajime Morrita 2012-02-26 22:19:09 PST 
Comment on attachment 128951 [details]
Patch

r=me assuming green bots.
Maybe typedef-ing NavigatorSupplement and PageSupplement will help to minimize the diff and
introducing future subclasses like NavigatorSupplement : public Supplement<Navigator> {};
Comment 3 Adam Barth 2012-02-26 22:20:38 PST 
I was kind of hoping we could avoid having typedefs or new subclasses.  It would certainly make the diff smaller though...
Comment 4 Adam Barth 2012-02-26 22:20:45 PST 
Thanks for the review.
Comment 5 Gyuyoung Kim 2012-02-26 22:23:39 PST 
Comment on attachment 128951 [details]
Patch

Attachment 128951 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11633768
Comment 6 Adam Barth 2012-02-26 22:33:52 PST 
Committed r108958: <http://trac.webkit.org/changeset/108958>