RESOLVED FIXED 79624
Extract Supplementable base class from Page and Navigator 
https://bugs.webkit.org/show_bug.cgi?id=79624
Summary Extract Supplementable base class from Page and Navigator
Adam Barth
Reported 2012-02-26 22:07:28 PST
Extract Supplementable base class from Page and Navigator
Attachments
Patch (52.97 KB, patch)
2012-02-26 22:08 PST, Adam Barth 		morrita: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-26 22:08:40 PST
Created attachment 128951 [details] Patch
Hajime Morrita
Comment 2 2012-02-26 22:19:09 PST
Comment on attachment 128951 [details] Patch r=me assuming green bots. Maybe typedef-ing NavigatorSupplement and PageSupplement will help to minimize the diff and introducing future subclasses like NavigatorSupplement : public Supplement<Navigator> {};
Adam Barth
Comment 3 2012-02-26 22:20:38 PST
I was kind of hoping we could avoid having typedefs or new subclasses. It would certainly make the diff smaller though...
Adam Barth
Comment 4 2012-02-26 22:20:45 PST
Thanks for the review.
Gyuyoung Kim
Comment 5 2012-02-26 22:23:39 PST
Comment on attachment 128951 [details] Patch Attachment 128951 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11633768
Adam Barth
Comment 6 2012-02-26 22:33:52 PST
Committed r108958: <http://trac.webkit.org/changeset/108958>
Note You need to log in before you can comment on or make changes to this bug.