WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79623
Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623
Summary
Add test case for ::selection:window-inactive
Daniel Bates
Reported
2012-02-26 21:54:18 PST
We should add a test case to ensure that we don't regress inactive selection. Inactive selection was implemented in <
http://trac.webkit.org/changeset/41094
> (
rdar://problem/6077775
).
Attachments
Layout test
(2.32 KB, patch)
2012-02-26 22:07 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2012-02-26 22:07:17 PST
Created
attachment 128950
[details]
Layout test
Daniel Bates
Comment 2
2012-02-26 22:08:51 PST
Additional remarks: We blend the background-color property, call this b, for ::selection with white unless b specifies an alpha value < 1 (255) by <
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderObject.cpp?rev=108719#L1612
>, <
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.cpp?rev=94452#L328
>, and <
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.h?rev=102740#L104
>.
WebKit Review Bot
Comment 3
2012-02-27 17:12:55 PST
Comment on
attachment 128950
[details]
Layout test Clearing flags on attachment: 128950 Committed
r109045
: <
http://trac.webkit.org/changeset/109045
>
WebKit Review Bot
Comment 4
2012-02-27 17:13:00 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug