Bug 79623 - Add test case for ::selection:window-inactive
Summary: Add test case for ::selection:window-inactive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 79890
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-26 21:54 PST by Daniel Bates
Modified: 2012-02-29 01:09 PST (History)
3 users (show)

See Also:

Attachments
Layout test (2.32 KB, patch)
2012-02-26 22:07 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2012-02-26 21:54:18 PST 
We should add a test case to ensure that we don't regress inactive selection. Inactive selection was implemented in <http://trac.webkit.org/changeset/41094> (rdar://problem/6077775).
Comment 1 Daniel Bates 2012-02-26 22:07:17 PST 
Created attachment 128950 [details]
Layout test
Comment 2 Daniel Bates 2012-02-26 22:08:51 PST 
Additional remarks:

We blend the background-color property, call this b, for ::selection with white unless b specifies an alpha value < 1 (255) by <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderObject.cpp?rev=108719#L1612>, <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.cpp?rev=94452#L328>, and <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/Color.h?rev=102740#L104>.
Comment 3 WebKit Review Bot 2012-02-27 17:12:55 PST 
Comment on attachment 128950 [details]
Layout test

Clearing flags on attachment: 128950

Committed r109045: <http://trac.webkit.org/changeset/109045>
Comment 4 WebKit Review Bot 2012-02-27 17:13:00 PST 
All reviewed patches have been landed.  Closing bug.