Bug 79612 - Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class
Summary: Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 18:36 PST by Sam Weinig
Modified: 2012-02-26 19:12 PST (History)
0 users

See Also:

Attachments
Patch (26.58 KB, patch)
2012-02-26 18:40 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-02-26 18:36:09 PST 
Refactor uses of WKSI to setup a remote layer into a new RemoteLayerClient class
Comment 1 Sam Weinig 2012-02-26 18:40:31 PST 
Created attachment 128938 [details]
Patch
Comment 2 Anders Carlsson 2012-02-26 18:45:13 PST 
Comment on attachment 128938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128938&action=review

> Source/WebKit2/Platform/mac/RemoteLayerClient.h:45
> +class RemoteLayerClient : public RefCounted<RemoteLayerClient> {

I don't think this needs to be refcounted. Just make it noncopyable and use OwnPtr instead of RefPtr.
Comment 3 Sam Weinig 2012-02-26 19:12:47 PST 
Committed r108946: <http://trac.webkit.org/changeset/108946>