Bug 79603 - [EFL] Support mutation observers
Summary: [EFL] Support mutation observers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 02:10 PST by ChangSeok Oh
Modified: 2012-02-27 16:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2012-02-26 07:39 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2012-02-27 07:14 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2012-02-26 02:10:30 PST 
This bug is for supporting DOM mutation observers.
If you need more information about mutation observers, please see http://www.w3.org/TR/dom/#mutation-observers.
Comment 1 ChangSeok Oh 2012-02-26 07:39:20 PST 
Created attachment 128914 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-02-26 13:27:25 PST 
Comment on attachment 128914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128914&action=review

> Source/cmake/OptionsEfl.cmake:85
> +WEBKIT_FEATURE(ENABLE_MUTATION_OBSERVERS "Enable HTML5 mutation observers support" DEFAULT OFF)

Any reason for the default not being ON here (it is enabled by default by build-webkit)?
Comment 3 ChangSeok Oh 2012-02-26 18:07:58 PST 
(In reply to comment #2)
> (From update of attachment 128914 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128914&action=review
> 
> > Source/cmake/OptionsEfl.cmake:85
> > +WEBKIT_FEATURE(ENABLE_MUTATION_OBSERVERS "Enable HTML5 mutation observers support" DEFAULT OFF)
> 
> Any reason for the default not being ON here (it is enabled by default by build-webkit)?

Nope. Let me change it. :)
Comment 4 Gyuyoung Kim 2012-02-26 18:49:22 PST 
Comment on attachment 128914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128914&action=review

>>> Source/cmake/OptionsEfl.cmake:85
>>> +WEBKIT_FEATURE(ENABLE_MUTATION_OBSERVERS "Enable HTML5 mutation observers support" DEFAULT OFF)
>> 
>> Any reason for the default not being ON here (it is enabled by default by build-webkit)?
> 
> Nope. Let me change it. :)

To run layout test, you should enable this option in build-webkit.
Comment 5 ChangSeok Oh 2012-02-27 07:14:56 PST 
Created attachment 129033 [details]
Patch
Comment 6 Eric Seidel (no email) 2012-02-27 15:11:45 PST 
Comment on attachment 129033 [details]
Patch

rs=me.
Comment 7 WebKit Review Bot 2012-02-27 16:36:30 PST 
Comment on attachment 129033 [details]
Patch

Clearing flags on attachment: 129033

Committed r109039: <http://trac.webkit.org/changeset/109039>
Comment 8 WebKit Review Bot 2012-02-27 16:36:35 PST 
All reviewed patches have been landed.  Closing bug.