Bug 79602 - Extract the logic to merge tests from MergeTestsHandler and add unit tests
Summary: Extract the logic to merge tests from MergeTestsHandler and add unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 01:22 PST by Ryosuke Niwa
Modified: 2012-02-27 18:14 PST (History)
2 users (show)

See Also:


Attachments
Patch (22.86 KB, patch)
2012-02-26 01:35 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Removed unnecessary handler rules in app.yaml (23.10 KB, patch)
2012-02-26 01:38 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-02-26 01:22:49 PST
The logic to merge tests in MergeTestsHandler is mission critical, and should be thoroughly unit-tested.
Comment 1 Ryosuke Niwa 2012-02-26 01:25:43 PST
Also, we can't be running this logic in frontend since merging a test with lots of TestResult would hit the process deadline.
Comment 2 Ryosuke Niwa 2012-02-26 01:35:11 PST
Created attachment 128910 [details]
Patch
Comment 3 Ryosuke Niwa 2012-02-26 01:38:53 PST
Created attachment 128911 [details]
Removed unnecessary handler rules in app.yaml
Comment 4 Ryosuke Niwa 2012-02-27 18:14:39 PST
Comment on attachment 128911 [details]
Removed unnecessary handler rules in app.yaml

Clearing flags on attachment: 128911

Committed r109057: <http://trac.webkit.org/changeset/109057>
Comment 5 Ryosuke Niwa 2012-02-27 18:14:43 PST
All reviewed patches have been landed.  Closing bug.