Bug 79600 – Implement the basis of KURLWTFURL

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Benjamin Poulain]

Make a not-optimized, working KURL based on WTFURL.

[Benjamin Poulain]

Created attachment 128907 [details]
Patch

Partial Implementation, no time to finish today

[Benjamin Poulain]

Created attachment 130010 [details]
Patch

[Adam Barth]

Comment on attachment 130010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130010&action=review

> Source/WebCore/platform/KURLWTFURL.cpp:103
> +        DEFINE_STATIC_LOCAL(const String, nullString, ());

This shouldn't really be needed.  A null string is just a value type anyway.

> Source/WebCore/platform/KURLWTFURL.cpp:219
> +    return WebCore::protocolIs(protocol(), testProtocol);

Part of the point of this function is to avoid the malloc.  This implementation keeps the malloc...

[Benjamin Poulain]

> > Source/WebCore/platform/KURLWTFURL.cpp:103
> > +        DEFINE_STATIC_LOCAL(const String, nullString, ());
> 
> This shouldn't really be needed.  A null string is just a value type anyway.

The trouble is this function return a reference (for now) :(

> > Source/WebCore/platform/KURLWTFURL.cpp:219
> > +    return WebCore::protocolIs(protocol(), testProtocol);
> 
> Part of the point of this function is to avoid the malloc.  This implementation keeps the malloc...

This is the case for many functions here (all the hasFooBar() for example). I just went for the easiest implementation and will optimize later.

Thanks for the review Adam.

[Benjamin Poulain]

Committed r109671: <http://trac.webkit.org/changeset/109671>