Bug 79593 - [Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
Summary: [Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-02-25 18:41 PST by Ryosuke Niwa
Modified: 2012-02-26 17:48 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2012-02-26 16:38 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-02-25 18:41:52 PST
http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/530/steps/perf-test/logs/stdio

Running Bindings/dom-attributes.html (1 of 44)
timeout: PerformanceTests/Bindings/dom-attributes.html
FAILED

Letting any test timeout is incredibly harmful on perf bots because we let each test run 10 minutes.
Comment 1 Ryosuke Niwa 2012-02-25 18:43:26 PST
Given the test is generating passing on Lion, I bet this is a bug in Chromium code or Chromium DumpRenderTree:

http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Perf%29/builds/459/steps/perf-test/logs/stdio
RESULT Bindings: dom-attributes= 8829.45 ms
median= 8839.5 ms, stdev= 32.2327085427 ms, min= 8770.0 ms, max= 8871.0 ms
Comment 2 Kentaro Hara 2012-02-26 16:38:38 PST
Created attachment 128934 [details]
Patch
Comment 3 Ryosuke Niwa 2012-02-26 16:50:48 PST
Comment on attachment 128934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128934&action=review

> PerformanceTests/ChangeLog:10
> +        V8 DOM bindings are too much slower than JSC bindings.

That's really bad. We should fix that. The results are also not reliable on Mac/Qt:
http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running

Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable?
Comment 4 Kentaro Hara 2012-02-26 16:59:19 PST
(In reply to comment #3)
> > PerformanceTests/ChangeLog:10
> > +        V8 DOM bindings are too much slower than JSC bindings.
> 
> That's really bad. We should fix that.

Yes, yes, yes, really. I've been investigating why (using my 20% time though).

> The results are also not reliable on Mac/Qt:
> http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running
> 
> Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable?

OK. But let me commit the patch to observe the reliability on the perf bots.
Comment 5 Ryosuke Niwa 2012-02-26 17:02:52 PST
(In reply to comment #4)
> (In reply to comment #3)
> > > PerformanceTests/ChangeLog:10
> > > +        V8 DOM bindings are too much slower than JSC bindings.
> > 
> > That's really bad. We should fix that.
> 
> Yes, yes, yes, really. I've been investigating why (using my 20% time though).
> 
> > The results are also not reliable on Mac/Qt:
> > http://webkit-perf.appspot.com/graph.html#tests=[[150153,2001,100137],[150153,2001,32196]]&sel=1330111816007.1082,1330303636915&displayrange=7&datatype=running
> > 
> > Could you investigate why that's the case? Do we just need more samples or are we doing something inherently unstable?
> 
> OK. But let me commit the patch to observe the reliability on the perf bots.

Sounds good to me.
Comment 6 WebKit Review Bot 2012-02-26 17:08:26 PST
Comment on attachment 128934 [details]
Patch

Attachment 128934 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11628770

New failing tests:
inspector/protocol/console-agent.html
Comment 7 WebKit Review Bot 2012-02-26 17:48:17 PST
Comment on attachment 128934 [details]
Patch

Clearing flags on attachment: 128934

Committed r108942: <http://trac.webkit.org/changeset/108942>
Comment 8 WebKit Review Bot 2012-02-26 17:48:22 PST
All reviewed patches have been landed.  Closing bug.