Bug 79577 - [Gtk][WK1] Use mock scrollbars when testing
Summary: [Gtk][WK1] Use mock scrollbars when testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-25 12:08 PST by Zan Dobersek
Modified: 2012-04-20 16:47 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-02-26 01:02 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2012-03-08 01:37 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-02-25 12:08:39 PST
WebKitTestRunner utilizes mock scrollbars when testing. This creates small pixel differences in render trees compared to already generated results. There is no need to generate WebKit2-specific results, rather than that the mock scrollbars should be used when testing with DumpRenderTree as well.

Such changes would need a lot of rebaselining, requiring careful approach.
Comment 1 Zan Dobersek 2012-02-26 01:02:20 PST
Created attachment 128909 [details]
Patch
Comment 2 Zan Dobersek 2012-02-26 01:04:53 PST
(In reply to comment #1)
> Created an attachment (id=128909) [details]
> Patch

This is just a preliminary patch, showing required changes to use mock scrollbars when running DumpRenderTree. I'll post some statistics about how many test results are affected, based upon r108931.
Comment 3 Zan Dobersek 2012-02-26 02:03:03 PST
Statistics for a release build of r108931, comparing to results at http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r108931%20(18789)/results.html

css1/
- 66 new text diff mismatches
css2.1/
- 31 new text diff mismatches
editing/
- 22 new text diff mismatches
fast/
- 365 new text diff mismatches
fonts/
- 6 new text diff mismatches
scrollbars/
- 1 new text diff mismatch
svg/
- 32 new text diff mismatches
tables/
- 125 new text diff mismatches
transforms/
- 2 new text diff mismatches
Comment 4 Zan Dobersek 2012-02-26 09:40:55 PST
(In reply to comment #3)
> Statistics for a release build of r108931, comparing to results at http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r108931%20(18789)/results.html
> 
> css1/
> - 66 new text diff mismatches
> css2.1/
> - 31 new text diff mismatches
> editing/
> - 22 new text diff mismatches
> fast/
> - 365 new text diff mismatches
> fonts/
> - 6 new text diff mismatches
> scrollbars/
> - 1 new text diff mismatch
> svg/
> - 32 new text diff mismatches
> tables/
> - 125 new text diff mismatches
> transforms/
> - 2 new text diff mismatches

Forgot to add results for http tests:
http/
- 3 new text diff mismatches
Comment 5 Zan Dobersek 2012-03-07 11:41:10 PST
With r110053, rebaseline is required for 659 tests. If I can get a thumbs-up, I'd like to proceed with creating proper patches for enabling mock scrollbars when testing and for rebaselines.
Comment 6 Martin Robinson 2012-03-07 11:52:01 PST
(In reply to comment #5)
> With r110053, rebaseline is required for 659 tests. If I can get a thumbs-up, I'd like to proceed with creating proper patches for enabling mock scrollbars when testing and for rebaselines.

Let's do this!
Comment 7 Zan Dobersek 2012-03-08 01:37:36 PST
Created attachment 130795 [details]
Patch

Patch for review
Comment 8 Zan Dobersek 2012-03-08 01:40:43 PST
(In reply to comment #7)
> Created an attachment (id=130795) [details]
> Patch
> 
> Patch for review

Rebaselines after these changes work well with WKTR too, meaning future differences between WKTR and DRT output are originating from other issues.

Land and rebaseline with care, the bots will go all volcano.
Comment 9 Daniel Bates 2012-04-20 15:41:04 PDT
Comment on attachment 130795 [details]
Patch

LGTM
Comment 10 Martin Robinson 2012-04-20 16:47:11 PDT
Comment on attachment 130795 [details]
Patch

Clearing flags on attachment: 130795

Committed r114799: <http://trac.webkit.org/changeset/114799>
Comment 11 Martin Robinson 2012-04-20 16:47:15 PDT
All reviewed patches have been landed.  Closing bug.