Bug 79577 – [Gtk][WK1] Use mock scrollbars when testing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Zan Dobersek]

WebKitTestRunner utilizes mock scrollbars when testing. This creates small pixel differences in render trees compared to already generated results. There is no need to generate WebKit2-specific results, rather than that the mock scrollbars should be used when testing with DumpRenderTree as well.

Such changes would need a lot of rebaselining, requiring careful approach.

[Zan Dobersek]

Created attachment 128909 [details]
Patch

[Zan Dobersek]

(In reply to comment #1)
> Created an attachment (id=128909) [details]
> Patch

This is just a preliminary patch, showing required changes to use mock scrollbars when running DumpRenderTree. I'll post some statistics about how many test results are affected, based upon r108931.

[Zan Dobersek]

Statistics for a release build of r108931, comparing to results at http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r108931%20(18789)/results.html

css1/
- 66 new text diff mismatches
css2.1/
- 31 new text diff mismatches
editing/
- 22 new text diff mismatches
fast/
- 365 new text diff mismatches
fonts/
- 6 new text diff mismatches
scrollbars/
- 1 new text diff mismatch
svg/
- 32 new text diff mismatches
tables/
- 125 new text diff mismatches
transforms/
- 2 new text diff mismatches

[Zan Dobersek]

(In reply to comment #3)
> Statistics for a release build of r108931, comparing to results at http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r108931%20(18789)/results.html
> 
> css1/
> - 66 new text diff mismatches
> css2.1/
> - 31 new text diff mismatches
> editing/
> - 22 new text diff mismatches
> fast/
> - 365 new text diff mismatches
> fonts/
> - 6 new text diff mismatches
> scrollbars/
> - 1 new text diff mismatch
> svg/
> - 32 new text diff mismatches
> tables/
> - 125 new text diff mismatches
> transforms/
> - 2 new text diff mismatches

Forgot to add results for http tests:
http/
- 3 new text diff mismatches

[Zan Dobersek]

With r110053, rebaseline is required for 659 tests. If I can get a thumbs-up, I'd like to proceed with creating proper patches for enabling mock scrollbars when testing and for rebaselines.

[Martin Robinson]

(In reply to comment #5)
> With r110053, rebaseline is required for 659 tests. If I can get a thumbs-up, I'd like to proceed with creating proper patches for enabling mock scrollbars when testing and for rebaselines.

Let's do this!

[Zan Dobersek]

Created attachment 130795 [details]
Patch

Patch for review

[Zan Dobersek]

(In reply to comment #7)
> Created an attachment (id=130795) [details]
> Patch
> 
> Patch for review

Rebaselines after these changes work well with WKTR too, meaning future differences between WKTR and DRT output are originating from other issues.

Land and rebaseline with care, the bots will go all volcano.

[Daniel Bates]

Comment on attachment 130795 [details]
Patch

LGTM

[Martin Robinson]

Comment on attachment 130795 [details]
Patch

Clearing flags on attachment: 130795

Committed r114799: <http://trac.webkit.org/changeset/114799>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.