Bug 79550 - Add media control css for chromium on android
Summary: Add media control css for chromium on android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 18:58 PST by Min Qin
Modified: 2012-03-05 11:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.08 KB, patch)
2012-02-24 19:03 PST, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (12.10 KB, patch)
2012-02-27 11:28 PST, Min Qin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-02-24 18:58:49 PST 
Add media control css for chromium on android
Comment 1 Min Qin 2012-02-24 19:03:53 PST 
Created attachment 128838 [details]
Patch
Comment 2 Adam Barth 2012-02-25 21:55:21 PST 
Comment on attachment 128838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128838&action=review

> Source/WebCore/rendering/RenderMediaControlsChromium.cpp:247
> +    static Image* mediaFullscreen = platformResource("mediaFullscreen");

Please use the DEFINE_STATIC_LOCAL macro.
Comment 3 Min Qin 2012-02-27 11:28:12 PST 
Created attachment 129076 [details]
Patch
Comment 4 Min Qin 2012-02-27 11:28:37 PST 
Done. switched to use DEFINE_STATIC_LOCAL
Comment 5 Min Qin 2012-03-05 09:10:32 PST 
ping. Is this change good to go now? 

Thanks
Min
Comment 6 Adam Barth 2012-03-05 10:12:02 PST 
Comment on attachment 129076 [details]
Patch

Yes, sorry.  Please feel free to ping me if it looks like I've forgotten something.
Comment 7 Min Qin 2012-03-05 10:28:23 PST 
Thank you, Adam.
Comment 8 WebKit Review Bot 2012-03-05 11:38:19 PST 
Comment on attachment 129076 [details]
Patch

Clearing flags on attachment: 129076

Committed r109776: <http://trac.webkit.org/changeset/109776>
Comment 9 WebKit Review Bot 2012-03-05 11:38:24 PST 
All reviewed patches have been landed.  Closing bug.