Bug 79543 - [Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
Summary: [Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords: Qt
Depends on: 79587
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 16:14 PST by Noam Rosenthal
Modified: 2012-03-03 11:27 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.02 KB, patch)
2012-02-24 16:19 PST, Noam Rosenthal
kenneth: review+
Details | Formatted Diff | Diff
Patch (4.04 KB, patch)
2012-02-25 07:47 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch - fixed API test problem (3.94 KB, patch)
2012-03-03 11:08 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-02-24 16:14:54 PST
... instead of figuring them out ourselves from the node tree.
Comment 1 Noam Rosenthal 2012-02-24 16:19:25 PST
Created attachment 128826 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-02-25 05:11:19 PST
Comment on attachment 128826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128826&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebpage_p_p.h:44
> +    void paintToCurrentGLContext(const QTransform&, float);

It is not obvious what the float represents here!
Comment 3 Noam Rosenthal 2012-02-25 07:47:57 PST
Created attachment 128865 [details]
Patch
Comment 4 WebKit Review Bot 2012-02-25 09:59:44 PST
Comment on attachment 128865 [details]
Patch

Clearing flags on attachment: 128865

Committed r108900: <http://trac.webkit.org/changeset/108900>
Comment 5 WebKit Review Bot 2012-02-25 09:59:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2012-02-25 13:26:00 PST
Reopen, because it made API test crash. Could you fix it?
Comment 7 Noam Rosenthal 2012-03-03 11:08:55 PST
Created attachment 130005 [details]
Patch - fixed API test problem
Comment 8 WebKit Review Bot 2012-03-03 11:26:56 PST
Comment on attachment 130005 [details]
Patch - fixed API test problem

Clearing flags on attachment: 130005

Committed r109664: <http://trac.webkit.org/changeset/109664>
Comment 9 WebKit Review Bot 2012-03-03 11:27:00 PST
All reviewed patches have been landed.  Closing bug.