RESOLVED FIXED 79543
[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode 
https://bugs.webkit.org/show_bug.cgi?id=79543
Summary [Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
Noam Rosenthal
Reported 2012-02-24 16:14:54 PST
... instead of figuring them out ourselves from the node tree.
Attachments
Patch (4.02 KB, patch)
2012-02-24 16:19 PST, Noam Rosenthal 		kenneth: review+
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2012-02-25 07:47 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch - fixed API test problem (3.94 KB, patch)
2012-03-03 11:08 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-02-24 16:19:25 PST
Created attachment 128826 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-02-25 05:11:19 PST
Comment on attachment 128826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128826&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebpage_p_p.h:44 > + void paintToCurrentGLContext(const QTransform&, float); It is not obvious what the float represents here!
Noam Rosenthal
Comment 3 2012-02-25 07:47:57 PST
Created attachment 128865 [details] Patch
WebKit Review Bot
Comment 4 2012-02-25 09:59:44 PST
Comment on attachment 128865 [details] Patch Clearing flags on attachment: 128865 Committed r108900: <http://trac.webkit.org/changeset/108900>
WebKit Review Bot
Comment 5 2012-02-25 09:59:49 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2012-02-25 13:26:00 PST
Reopen, because it made API test crash. Could you fix it?
Noam Rosenthal
Comment 7 2012-03-03 11:08:55 PST
Created attachment 130005 [details] Patch - fixed API test problem
WebKit Review Bot
Comment 8 2012-03-03 11:26:56 PST
Comment on attachment 130005 [details] Patch - fixed API test problem Clearing flags on attachment: 130005 Committed r109664: <http://trac.webkit.org/changeset/109664>
WebKit Review Bot
Comment 9 2012-03-03 11:27:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.