Bug 79534 - [chromium] Provide DefaultDeviceScaleFactor though WebSettings
Summary: [chromium] Provide DefaultDeviceScaleFactor though WebSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 14:52 PST by Tim Dresser
Modified: 2012-02-28 15:05 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2012-02-24 15:02 PST, Tim Dresser 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Dresser 2012-02-24 14:52:03 PST 
DefaultDeviceScaleFactor will be based solely on the screen DPI, as opposed to DeviceScaleFactor, which incorporates information from the viewport tag.
Comment 1 Tim Dresser 2012-02-24 15:02:39 PST 
Created attachment 128816 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-02-24 16:54:00 PST 
What does NOT FOR REVIEW in the bug title mean? Shouldn't it be on patch name instead?
Comment 3 Robert Kroeger 2012-02-27 07:06:50 PST 
Comment on attachment 128816 [details]
Patch

Looks reasonable to me.
Comment 4 Simon Fraser (smfr) 2012-02-27 09:54:36 PST 
It's not clear to me that deviceScaleFactor should be affected by viewport tag settings. Would it change as the user zooms?
Comment 5 Robert Kroeger 2012-02-27 10:49:09 PST 
My apologies for the spam. I asked Tim to ask Darin, meaning fishd@ but he obediently added darin@ to the CC list.

smfr@: in chromium, the viewport tag lets a web page author specify the devicePixelRatio of the page. However, we want the popup portion of <select> tags to obey the default device scale factor -- not a device scale factor modified by the viewport tag of the initiating page. Hence the additional integer parameter.

fishd@: could you take a look at this CL?
Comment 6 WebKit Review Bot 2012-02-28 15:05:39 PST 
Comment on attachment 128816 [details]
Patch

Clearing flags on attachment: 128816

Committed r109155: <http://trac.webkit.org/changeset/109155>
Comment 7 WebKit Review Bot 2012-02-28 15:05:44 PST 
All reviewed patches have been landed.  Closing bug.