WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79512
Use xcrun to find compiler paths for Generate Derived Sources build phase script
https://bugs.webkit.org/show_bug.cgi?id=79512
Summary
Use xcrun to find compiler paths for Generate Derived Sources build phase script
David Kilzer (:ddkilzer)
Reported
2012-02-24 11:09:55 PST
Created
attachment 128768
[details]
Patch <http://webkit.org/b/00000> Reviewed by NOBODY (OOPS!). * WebCore.xcodeproj/project.pbxproj: (Generate Derived Sources): Use xcrun to find the path to the compiler since that works on both iOS and OS X. --- 2 files changed, 12 insertions(+), 1 deletions(-)
Attachments
Patch
(2.63 KB, patch)
2012-02-24 11:09 PST
,
David Kilzer (:ddkilzer)
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2012-02-24 11:13:17 PST
Attachment 128768
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 2
2012-02-24 11:22:31 PST
Committed
r108826
: <
http://trac.webkit.org/changeset/108826
>
David Kilzer (:ddkilzer)
Comment 3
2012-02-24 12:37:41 PST
Follow-up fix noted and reviewed by Dan Bernstein: Committed
r108836
: <
http://trac.webkit.org/changeset/108836
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug