Bug 79508 - Switch indexeddb to use supplemental IDL for WorkerContext
Summary: Switch indexeddb to use supplemental IDL for WorkerContext
Status: RESOLVED DUPLICATE of bug 80094
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 10:44 PST by Mark Pilgrim (Google)
Modified: 2012-03-16 08:15 PDT (History)
4 users (show)

See Also:


Attachments
[WIP] Patch (8.32 KB, patch)
2012-02-24 10:46 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
[WIP] Patch (16.08 KB, patch)
2012-02-24 10:48 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (15.44 KB, patch)
2012-02-24 11:04 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-02-24 10:44:40 PST
Switch indexeddb to use supplemental IDL for WorkerContext
Comment 1 Mark Pilgrim (Google) 2012-02-24 10:46:09 PST
Created attachment 128758 [details]
[WIP] Patch
Comment 2 Mark Pilgrim (Google) 2012-02-24 10:48:55 PST
Created attachment 128759 [details]
[WIP] Patch
Comment 3 Adam Barth 2012-02-24 10:49:29 PST
Comment on attachment 128758 [details]
[WIP] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128758&action=review

> Source/WebCore/workers/WorkerContext.h:177
>  #if ENABLE(INDEXED_DATABASE)
> -        IDBFactory* webkitIndexedDB() const;
> +        IDBFactory* idbFactory() { return m_idbFactory.get(); }
> +        void setIDBFactory(PassRefPtr<IDBFactory>);
> +        IDBFactoryBackendInterface* idbFactoryBackendInterface() { return m_idbFactoryBackendInterface.get(); }
> +        void setIDBFactoryBackendInterface(PassRefPtr<IDBFactoryBackendInterface>);
>  #endif

We should be able to remove the ENABLE(INDEXED_DATABASE) from WorkerContext using something analogous to PageSupplement.  It might be slightly trickier though because WorkerContext is used on many threads.
Comment 4 WebKit Review Bot 2012-02-24 11:02:27 PST
Comment on attachment 128759 [details]
[WIP] Patch

Attachment 128759 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11627106
Comment 5 Mark Pilgrim (Google) 2012-02-24 11:04:46 PST
Created attachment 128766 [details]
Patch
Comment 6 Hajime Morrita 2012-03-15 21:18:34 PDT
Comment on attachment 128766 [details]
Patch

Looks like abarth snached  this at Bug 80094 :-/
Comment 7 Mark Pilgrim (Google) 2012-03-16 08:15:53 PDT

*** This bug has been marked as a duplicate of bug 80094 ***