RESOLVED DUPLICATE of bug 80094 79508
Switch indexeddb to use supplemental IDL for WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=79508
Summary Switch indexeddb to use supplemental IDL for WorkerContext
Mark Pilgrim (Google)
Reported 2012-02-24 10:44:40 PST
Switch indexeddb to use supplemental IDL for WorkerContext
Attachments
[WIP] Patch (8.32 KB, patch)
2012-02-24 10:46 PST, Mark Pilgrim (Google)
no flags
[WIP] Patch (16.08 KB, patch)
2012-02-24 10:48 PST, Mark Pilgrim (Google)
no flags
Patch (15.44 KB, patch)
2012-02-24 11:04 PST, Mark Pilgrim (Google)
no flags
Mark Pilgrim (Google)
Comment 1 2012-02-24 10:46:09 PST
Created attachment 128758 [details] [WIP] Patch
Mark Pilgrim (Google)
Comment 2 2012-02-24 10:48:55 PST
Created attachment 128759 [details] [WIP] Patch
Adam Barth
Comment 3 2012-02-24 10:49:29 PST
Comment on attachment 128758 [details] [WIP] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128758&action=review > Source/WebCore/workers/WorkerContext.h:177 > #if ENABLE(INDEXED_DATABASE) > - IDBFactory* webkitIndexedDB() const; > + IDBFactory* idbFactory() { return m_idbFactory.get(); } > + void setIDBFactory(PassRefPtr<IDBFactory>); > + IDBFactoryBackendInterface* idbFactoryBackendInterface() { return m_idbFactoryBackendInterface.get(); } > + void setIDBFactoryBackendInterface(PassRefPtr<IDBFactoryBackendInterface>); > #endif We should be able to remove the ENABLE(INDEXED_DATABASE) from WorkerContext using something analogous to PageSupplement. It might be slightly trickier though because WorkerContext is used on many threads.
WebKit Review Bot
Comment 4 2012-02-24 11:02:27 PST
Comment on attachment 128759 [details] [WIP] Patch Attachment 128759 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11627106
Mark Pilgrim (Google)
Comment 5 2012-02-24 11:04:46 PST
Hajime Morrita
Comment 6 2012-03-15 21:18:34 PDT
Comment on attachment 128766 [details] Patch Looks like abarth snached this at Bug 80094 :-/
Mark Pilgrim (Google)
Comment 7 2012-03-16 08:15:53 PDT
*** This bug has been marked as a duplicate of bug 80094 ***
Note You need to log in before you can comment on or make changes to this bug.