Bug 79501 - [Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
Summary: [Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2012-02-24 09:43 PST by Noam Rosenthal
Modified: 2012-02-29 20:23 PST (History)
6 users (show)

See Also:


Attachments
Patch (20.80 KB, patch)
2012-02-27 09:09 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (20.88 KB, patch)
2012-02-29 10:04 PST, Noam Rosenthal
noam: commit-queue+
Details | Formatted Diff | Diff
Patch (20.73 KB, patch)
2012-02-29 13:36 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-02-24 09:43:57 PST
We use a wide set of #ifdefs to encapsulate the LayerTreeHostProxy implemetation, and to encapsulate the TILED_BACKING_STORE parts of it.
Instead, we should use a single guard (maybe USE(COMPOSITING_IN_UI_PROCESS) and remove the TILED_BACKING_STORE guard.
Comment 1 Noam Rosenthal 2012-02-27 09:09:16 PST
Created attachment 129048 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-02-29 06:53:40 PST
I don't think this is clear enough. It sounds as if is for enabling the code on the UI process, but not doing the actual compositing there.

What about WTF_USE_UI_SIDE_COMPOSITING ? WTF_CLIENT_SIDE_COMPOSITING
Comment 3 Noam Rosenthal 2012-02-29 10:04:51 PST
Created attachment 129466 [details]
Patch
Comment 4 Noam Rosenthal 2012-02-29 13:36:47 PST
Created attachment 129507 [details]
Patch
Comment 5 WebKit Review Bot 2012-02-29 20:22:57 PST
Comment on attachment 129507 [details]
Patch

Clearing flags on attachment: 129507

Committed r109302: <http://trac.webkit.org/changeset/109302>
Comment 6 WebKit Review Bot 2012-02-29 20:23:02 PST
All reviewed patches have been landed.  Closing bug.