Bug 79488 - Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
Summary: Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 07:32 PST by epoger
Modified: 2012-02-24 12:07 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.65 KB, patch)
2012-02-24 10:50 PST, epoger 		no flags Details | Formatted Diff | Diff
Patch (5.65 KB, patch)
2012-02-24 10:52 PST, epoger 		no flags Details | Formatted Diff | Diff
Patch (7.62 KB, patch)
2012-02-24 11:10 PST, epoger 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2012-02-24 07:32:02 PST 
I plan to modify the fast/canvas/canvas-strokePath-shadow.html layout test to be less fragile, by allowing for pixel tolerance.

See https://chromiumcodereview.appspot.com/9447055/ ('Roll Skia DEPS 3230->3244')
Comment 1 epoger 2012-02-24 10:50:32 PST 
Created attachment 128760 [details]
Patch
Comment 2 epoger 2012-02-24 10:52:54 PST 
Created attachment 128761 [details]
Patch
Comment 3 epoger 2012-02-24 11:10:08 PST 
Created attachment 128770 [details]
Patch
Comment 4 epoger 2012-02-24 11:11:46 PST 
As noted in https://chromiumcodereview.appspot.com/9447055/ ('Roll Skia DEPS 3230->3244'), the following layout test will fail until this change (or a test_expectations change) is landed in WebKit:

GPU : fast/canvas/canvas-strokePath-shadow.html
Comment 5 WebKit Review Bot 2012-02-24 12:07:26 PST 
Comment on attachment 128770 [details]
Patch

Clearing flags on attachment: 128770

Committed r108835: <http://trac.webkit.org/changeset/108835>
Comment 6 WebKit Review Bot 2012-02-24 12:07:30 PST 
All reviewed patches have been landed.  Closing bug.