Bug 79486 - [Qt] API: Unify the loading properties and signals.
Summary: [Qt] API: Unify the loading properties and signals.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks: 74403
  Show dependency treegraph
 
Reported: 2012-02-24 06:35 PST by Jocelyn Turcotte
Modified: 2012-02-24 09:51 PST (History)
6 users (show)

See Also:


Attachments
Patch (73.22 KB, patch)
2012-02-24 06:44 PST, Jocelyn Turcotte
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-02-24 06:35:44 PST
[Qt] API: Unify the loading properties and signals.
Comment 1 Jocelyn Turcotte 2012-02-24 06:44:35 PST
Created attachment 128725 [details]
Patch
Comment 2 Simon Hausmann 2012-02-24 08:03:01 PST
Comment on attachment 128725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128725&action=review

r=me.

The only iffy thing that I think can be easily fixed if it actually turns out to be a problem (I'm not sure it is), is that the argument to the loadingChanged signal is very short-lived. This isn't quite specific to this patch, but perhaps we should consider using actual JavaScript objects as parameters (QJSValue) with according properties. (or JSON if you want so :)

> Source/WebKit2/UIProcess/API/qt/qwebloadrequest_p.h:47
> +    QWebLoadRequestPrivate* d;

As a general rule perhaps we should consider adopting the Qt rule of using QScopedPointer for the d-pointer.
Comment 3 Jocelyn Turcotte 2012-02-24 09:51:13 PST
Committed r108815: <http://trac.webkit.org/changeset/108815>