Bug 79476 - Refactor EventHandler::handleGestureEvent
Summary: Refactor EventHandler::handleGestureEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 78801
  Show dependency treegraph
 
Reported: 2012-02-24 04:57 PST by Allan Sandfeld Jensen
Modified: 2012-02-24 07:03 PST (History)
1 user (show)

See Also:


Attachments
Patch (6.36 KB, patch)
2012-02-24 05:00 PST, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-02-24 04:57:27 PST
The handling of specific gesture events should be moved out of the switch statement in handleGestureEvent. Especially since they will become more complicated as the issues in them are resolved.

Additionally the two gesture events tap and scrollupdate events could return better return-values even is the return value is not currently used.
Comment 1 Allan Sandfeld Jensen 2012-02-24 05:00:07 PST
Created attachment 128711 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-24 07:00:58 PST
The commit-queue encountered the following flaky tests while processing attachment 128711 [details]:

storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Review Bot 2012-02-24 07:03:04 PST
Comment on attachment 128711 [details]
Patch

Clearing flags on attachment: 128711

Committed r108793: <http://trac.webkit.org/changeset/108793>
Comment 4 WebKit Review Bot 2012-02-24 07:03:08 PST
All reviewed patches have been landed.  Closing bug.