Bug 79469 - DFG should be able to handle variables getting captured
Summary: DFG should be able to handle variables getting captured
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 03:13 PST by Filip Pizlo
Modified: 2012-02-24 13:32 PST (History)
1 user (show)

See Also:

Attachments
the patch (48.72 KB, patch)
2012-02-24 03:19 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-02-24 03:13:53 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-02-24 03:14:06 PST 
This is a prerequisite to supporting activations.
Comment 2 Filip Pizlo 2012-02-24 03:19:43 PST 
Created attachment 128699 [details]
the patch
Comment 3 WebKit Commit Bot 2012-02-24 03:21:40 PST 
Attachment 128699 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGGraph.h:317:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2012-02-24 11:48:19 PST 
Comment on attachment 128699 [details]
the patch

r=me
Comment 5 Filip Pizlo 2012-02-24 13:32:05 PST 
Landed in http://trac.webkit.org/changeset/108842