Bug 79465 - Tests for showModalDialog need to ask for permission to open windows
: Tests for showModalDialog need to ask for permission to open windows
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: jochen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 01:53 PST by jochen
Modified: 2012-02-24 14:02 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2012-02-24 02:04 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-02-24 01:53:12 PST
Fix fast/events/scroll-event-during-modal-dialog.html so it actually displays a modal dialog
Comment 1 jochen 2012-02-24 02:03:43 PST
affects fast/animation/request-animation-frame-during-modal.html as well
Comment 2 jochen 2012-02-24 02:04:22 PST
Created attachment 128692 [details]
Patch
Comment 3 WebKit Review Bot 2012-02-24 06:08:55 PST
Comment on attachment 128692 [details]
Patch

Clearing flags on attachment: 128692

Committed r108783: <http://trac.webkit.org/changeset/108783>
Comment 4 WebKit Review Bot 2012-02-24 06:09:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-02-24 13:59:59 PST
Why? Does popup blocker affect modal dialogs?
Comment 6 jochen 2012-02-24 14:02:44 PST
(In reply to comment #5)
> Why? Does popup blocker affect modal dialogs?

yes (at least on chromium)