Bug 79463 - Update .gitignore for project property files generated by Eclipse.
Summary: Update .gitignore for project property files generated by Eclipse.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Changwan Hong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 01:34 PST by Changwan Hong
Modified: 2012-02-26 21:06 PST (History)
3 users (show)

See Also:


Attachments
Patch (898 bytes, patch)
2012-02-24 01:36 PST, Changwan Hong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Changwan Hong 2012-02-24 01:34:44 PST
Update .gitignore for project property files generated by Eclipse.
Comment 1 Changwan Hong 2012-02-24 01:36:26 PST
Created attachment 128683 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-24 01:40:04 PST
Comment on attachment 128683 [details]
Patch

Rejecting attachment 128683 [details] from review queue.

jourmoon@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 3 WebKit Review Bot 2012-02-24 01:41:24 PST
Comment on attachment 128683 [details]
Patch

Rejecting attachment 128683 [details] from commit-queue.

jourmoon@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2012-02-24 02:01:23 PST
Comment on attachment 128683 [details]
Patch

Rejecting attachment 128683 [details] from review queue.

jourmoon@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Review Bot 2012-02-24 02:02:18 PST
Comment on attachment 128683 [details]
Patch

Rejecting attachment 128683 [details] from commit-queue.

jourmoon@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 Simon Hausmann 2012-02-24 02:13:16 PST
Comment on attachment 128683 [details]
Patch

Clearing review since the bot seems to have gone roque on it :). If you want to mark a patch for review, set r? (and cq? if you want it to go through commit queue).
Comment 7 Andreas Kling 2012-02-26 19:15:46 PST
Comment on attachment 128683 [details]
Patch

Seems harmless. rs=me
Comment 8 WebKit Review Bot 2012-02-26 21:06:03 PST
Comment on attachment 128683 [details]
Patch

Clearing flags on attachment: 128683

Committed r108953: <http://trac.webkit.org/changeset/108953>
Comment 9 WebKit Review Bot 2012-02-26 21:06:08 PST
All reviewed patches have been landed.  Closing bug.