Bug 79462 - Should not allow malformed \x escapes
Summary: Should not allow malformed \x escapes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 00:50 PST by Gavin Barraclough
Modified: 2012-02-24 13:15 PST (History)
1 user (show)

See Also:


Attachments
Fix (11.84 KB, patch)
2012-02-24 00:54 PST, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-02-24 00:50:01 PST
The spec requires \x in strings to be followed by two hex digits; Chrome appears to enforce this, so conforming with the spec here should be pretty safe.
Comment 1 Gavin Barraclough 2012-02-24 00:54:29 PST
Created attachment 128682 [details]
Fix
Comment 2 WebKit Commit Bot 2012-02-24 02:37:53 PST
Attachment 128682 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/tests/mozilla/js1_2/regexp/hexadecimal.js:33:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/tests/mozilla/ecma/LexicalConventions/7.7.4.js:175:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2012-02-24 13:15:53 PST
Fixed in r108841