RESOLVED FIXED Bug 79458
[WK2][Qt] Fix compilation without QtWidgets 
https://bugs.webkit.org/show_bug.cgi?id=79458
Summary [WK2][Qt] Fix compilation without QtWidgets
Simon Hausmann
Reported 2012-02-24 00:19:02 PST
As pointed our by Yael, qquickwebview.cpp uses QFileDialog, which requires the use of QT += widgets when compiling the WebKit2 static library. We should delegate all Widget dependencies into the WebKit1 static library and use them from the WK2 one (that means building WK1 before WK2). The intermediate goal is to compile WebCore and WK2 without Widgets, regardless of the fact that the resulting shared library has a dependency to QtWidgets. By avoiding the dependency in those two static libraries we reduce the risk of accidentally introducing new dependencies.
Attachments
Patch (7.30 KB, patch)
2012-03-18 08:33 PDT, Simon Hausmann 		vestbo: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-03-18 08:33:43 PDT
Created attachment 132492 [details] Patch
Build Bot
Comment 2 2012-03-19 12:35:21 PDT
Comment on attachment 132492 [details] Patch Attachment 132492 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11981852
Simon Hausmann
Comment 3 2012-03-26 08:07:01 PDT
Committed r112093: <http://trac.webkit.org/changeset/112093>
Balazs Kelemen
Comment 4 2012-03-27 10:06:20 PDT
One more place where QApplication::wheelScrollLines is used (actually compiles but makes minibrowser --desktop not react on wheel scroll): https://bugs.webkit.org/show_bug.cgi?id=81938. r? :)
Simon Hausmann
Comment 5 2012-03-30 00:23:33 PDT
*** Bug 81938 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.