Move FILE_SYSTEM code out of WorkerContext and into the fileapi/WorkerContextFileSystem folder[1]. [1]: https://docs.google.com/spreadsheet/ccc?key=0AppchfQ5mBrEdFlodHlLb0prdEd1ZEZyUHdCbEpoc2c#gid=0
Created attachment 128863 [details] Patch
Attachment 128863 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/fileapi/WorkerContextFileSystem.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 128863 [details] Patch Attachment 128863 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11632335
Created attachment 128864 [details] Patch
Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11627441
Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11629405
Comment on attachment 128864 [details] Patch Attachment 128864 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11626400
Comment on attachment 128864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128864&action=review Looks like you're having some trouble building. > Source/WebCore/fileapi/WorkerContextFileSystem.h:44 > + void webkitRequestFileSystem(int type, long long size, PassRefPtr<FileSystemCallback> successCallback, PassRefPtr<ErrorCallback>); > + PassRefPtr<DOMFileSystemSync> webkitRequestFileSystemSync(int type, long long size, ExceptionCode&); > + void webkitResolveLocalFileSystemURL(const String& url, PassRefPtr<EntryCallback> successCallback, PassRefPtr<ErrorCallback>); > + PassRefPtr<EntrySync> webkitResolveLocalFileSystemSyncURL(const String& url, ExceptionCode&); These all should be static and take a WorkerContext as the first argument. Also, WorkerContextFileSystem should have a private constructor and destructor, like DOMWindowFileSystem. > Source/WebCore/workers/WorkerContext.h:130 > + // FIXME: Move these constants to WorkerContextFileSystem. You should be able to move these now. We didn't move them right away in the other patch because of a bug in the code generator that has since been fixed.
Created attachment 128915 [details] Patch
Comment on attachment 128915 [details] Patch Attachment 128915 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11627727
Attachment 128915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 128917 [details] Patch
Comment on attachment 128917 [details] Patch Attachment 128917 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11626667
Comment on attachment 128917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128917&action=review > Source/WebCore/GNUmakefile.list.am:4871 > + $(WebCore)/fileapi/WorkerContextFileSystem.idl \ Remove trailing backslah. That should make EWS happier.
Created attachment 128918 [details] Patch
Comment on attachment 128918 [details] Patch Attachment 128918 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11627736
Comment on attachment 128918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128918&action=review > Source/WebCore/GNUmakefile.list.am:4871 > $(WebCore)/fileapi/MetadataCallback.idl > + $(WebCore)/fileapi/WorkerContextFileSystem.idl \ This won't work either. Move the backslash to the end of previous line: $(WebCore)/fileapi/MetadataCallback.idl \ $(WebCore)/fileapi/WorkerContextFileSystem.idl (without forgetting the tabulations :)
Comment on attachment 128918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128918&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Looks like you're getting close. You'll need to remove this land before we can land your patch. I'd probably replace it with a sentence that says that there shouldn't be any change in behavior from this patch (and therefore there's nothing to test).
Created attachment 128923 [details] Patch
Comment on attachment 128923 [details] Patch Attachment 128923 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11632682
Created attachment 128942 [details] Patch
The patch has passed the build scripts and is ready for review.
Comment on attachment 128942 [details] Patch Looks great. Thanks.
Comment on attachment 128942 [details] Patch Clearing flags on attachment: 128942 Committed r109133: <http://trac.webkit.org/changeset/109133>
All reviewed patches have been landed. Closing bug.