WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79442
Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
https://bugs.webkit.org/show_bug.cgi?id=79442
Summary
Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
Kentaro Hara
Reported
2012-02-23 21:53:01 PST
For WebKit modularization, we can move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl.
Attachments
Patch
(6.36 KB, patch)
2012-02-23 21:55 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
patch for landing
(6.28 KB, patch)
2012-02-24 01:41 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-02-23 21:55:33 PST
Created
attachment 128650
[details]
Patch
Adam Barth
Comment 2
2012-02-23 23:03:04 PST
Comment on
attachment 128650
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=128650&action=review
> Source/WebCore/workers/DOMWindowWorker.idl:31 > +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS > + attribute WorkerConstructor Worker; // Usable with the new operator > +#endif > + > +#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS > + attribute [JSCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator > +#endif
Can we use Conditional here? It's prettier.
Kentaro Hara
Comment 3
2012-02-24 01:41:32 PST
Created
attachment 128685
[details]
patch for landing
Kentaro Hara
Comment 4
2012-02-24 01:42:12 PST
(In reply to
comment #2
)
> Can we use Conditional here? It's prettier.
Done.
WebKit Review Bot
Comment 5
2012-02-24 05:33:06 PST
Comment on
attachment 128685
[details]
patch for landing Clearing flags on attachment: 128685 Committed
r108778
: <
http://trac.webkit.org/changeset/108778
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug