Bug 79442 - Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
Summary: Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-02-23 21:53 PST by Kentaro Hara
Modified: 2012-02-24 05:35 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.36 KB, patch)
2012-02-23 21:55 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (6.28 KB, patch)
2012-02-24 01:41 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-23 21:53:01 PST 
For WebKit modularization, we can move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl.
Comment 1 Kentaro Hara 2012-02-23 21:55:33 PST 
Created attachment 128650 [details]
Patch
Comment 2 Adam Barth 2012-02-23 23:03:04 PST 
Comment on attachment 128650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128650&action=review

> Source/WebCore/workers/DOMWindowWorker.idl:31
> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS
> +        attribute WorkerConstructor Worker; // Usable with the new operator
> +#endif
> +
> +#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
> +        attribute [JSCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
> +#endif

Can we use Conditional here?  It's prettier.
Comment 3 Kentaro Hara 2012-02-24 01:41:32 PST 
Created attachment 128685 [details]
patch for landing
Comment 4 Kentaro Hara 2012-02-24 01:42:12 PST 
(In reply to comment #2)
> Can we use Conditional here?  It's prettier.

Done.
Comment 5 WebKit Review Bot 2012-02-24 05:33:06 PST 
Comment on attachment 128685 [details]
patch for landing

Clearing flags on attachment: 128685

Committed r108778: <http://trac.webkit.org/changeset/108778>