Bug 79434 - Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
Summary: Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-02-23 20:33 PST by Kentaro Hara
Modified: 2012-03-02 04:28 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.43 KB, patch)
2012-02-23 20:35 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (9.50 KB, patch)
2012-02-24 04:33 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-23 20:33:47 PST 
For WebKit modularization, we can move XML-related APIs from DOMWindow.idl to DOMWIndowXML.idl.
Comment 1 Kentaro Hara 2012-02-23 20:35:54 PST 
Created attachment 128641 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-24 03:58:16 PST 
Comment on attachment 128641 [details]
Patch

Rejecting attachment 128641 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:

Hunk #2 succeeded at 20011 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/page/DOMWindow.idl
Hunk #1 succeeded at 437 (offset -8 lines).
Hunk #2 succeeded at 466 (offset -8 lines).
patching file Source/WebCore/xml/DOMWindowXML.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11608957
Comment 3 Kentaro Hara 2012-02-24 04:33:54 PST 
Created attachment 128707 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-02-24 06:37:20 PST 
Comment on attachment 128707 [details]
patch for landing

Clearing flags on attachment: 128707

Committed r108787: <http://trac.webkit.org/changeset/108787>