RESOLVED FIXED 79427
Move ChromeClient::showContextMenu() to ContextMenuClient 
https://bugs.webkit.org/show_bug.cgi?id=79427
Summary Move ChromeClient::showContextMenu() to ContextMenuClient
Hajime Morrita
Reported 2012-02-23 18:10:18 PST
Looks like a historical artifact.
Attachments
Patch (17.75 KB, patch)
2012-02-23 18:19 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (35.04 KB, patch)
2012-02-23 22:50 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (35.04 KB, patch)
2012-02-24 01:59 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (35.26 KB, patch)
2012-02-26 18:13 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (35.21 KB, patch)
2012-02-26 20:50 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-23 18:19:01 PST
Created attachment 128626 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-23 18:21:00 PST
Comment on attachment 128626 [details] Patch Really? Mac doesn't ever call this?
Hajime Morrita
Comment 3 2012-02-23 18:26:39 PST
Comment on attachment 128626 [details] Patch Oops. I found there was only one place in accessibility... that's why chromium can build without this.
Hajime Morrita
Comment 4 2012-02-23 22:50:36 PST
Created attachment 128655 [details] Patch
Hajime Morrita
Comment 5 2012-02-24 01:59:39 PST
Created attachment 128691 [details] Patch
Hajime Morrita
Comment 6 2012-02-26 18:13:12 PST
Created attachment 128936 [details] Patch
Adam Barth
Comment 7 2012-02-26 20:14:03 PST
Comment on attachment 128936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128936&action=review > Source/WebCore/ChangeLog:10 > + This change localizes context menu relted code and will make it easy to typo: relted
Hajime Morrita
Comment 8 2012-02-26 20:50:47 PST
Created attachment 128946 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-02-26 22:25:46 PST
The commit-queue encountered the following flaky tests while processing attachment 128946 [details]: inspector/protocol/console-agent.html bug 79563 (authors: caseq@chromium.org, loislo@chromium.org, and pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 10 2012-02-26 22:31:16 PST
Comment on attachment 128946 [details] Patch for landing Clearing flags on attachment: 128946 Committed r108957: <http://trac.webkit.org/changeset/108957>
WebKit Review Bot
Comment 11 2012-02-26 22:31:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.