Bug 79425 - [chromium] Move Web*Layer* headers into Platform
Summary: [chromium] Move Web*Layer* headers into Platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 79428
  Show dependency tree / graph
 
Reported: 2012-02-23 17:31 PST by James Robinson
Modified: 2012-02-24 11:29 PST (History)
9 users (show)

See Also:

Attachments
Patch (76.11 KB, patch)
2012-02-23 17:33 PST, James Robinson 		abarth: review+
Details | Formatted Diff | Diff
Patch (14.70 KB, text/plain)
2012-02-24 04:31 PST, Andrey Kosyakov 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-02-23 17:31:19 PST 
[chromium] Move Web*Layer* headers into Platform
Comment 1 James Robinson 2012-02-23 17:33:22 PST 
Created attachment 128616 [details]
Patch
Comment 2 James Robinson 2012-02-23 17:35:11 PST 
This moves Web*Layer* headers over to Platform so that I can start depending on these inside WebCore.  This will conflict with the changes to WebLayerTreeView in https://bugs.webkit.org/show_bug.cgi?id=75591, after I land whichever one I can get a review on first I'll take care of the conflicts to the other patch.
Comment 3 WebKit Commit Bot 2012-02-24 02:16:28 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 WebKit Commit Bot 2012-02-24 02:16:37 PST 
Attachment 128616 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/Platform/chromium/public/WebPrivatePtr.h:42:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebColorName.h:69:  One space before end of line comments  [whitespace/comments] [5]
Source/Platform/chromium/public/WebColor.h:39:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andrey Kosyakov 2012-02-24 04:31:59 PST 
Created attachment 128706 [details]
Patch
Comment 6 Andrey Kosyakov 2012-02-24 04:36:15 PST 
Comment on attachment 128706 [details]
Patch

Please disregard my attachment, uploaded to a wrong bug, sorry!
Comment 7 James Robinson 2012-02-24 11:29:06 PST 
Committed r108829: <http://trac.webkit.org/changeset/108829>