Bug 79387 – Limit WebGL Errors in Console to 10 per context

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Gregg Tavares]

Limit WebGL Errors in Console to 10 per context

[Gregg Tavares]

Created attachment 128529 [details]
Patch

[Kenneth Russell]

Comment on attachment 128529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128529&action=review

Looks good but would you mind doing one small refactoring to make maintenance easier?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:429
> +    , m_numGLErrorsToConsoleAllowed(10)

Could you define a const int maxGLErrorsAllowedToConsole at the top of the file and initialize this to that?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:470
> +    m_numGLErrorsToConsoleAllowed = 10;

Same here.

[Gregg Tavares]

Created attachment 128779 [details]
Patch

[Gregg Tavares]

Comment on attachment 128779 [details]
Patch

added constant.

Just fyi though, It's frustrating to be held to a different standard than the existing code. The reason I didn't use a constant is because the code just a few lines above is not using a constant. The #1 rule I've been taught is to be consistent and follow the style of the code being modified which is what I did.

The point is, if you want a certain style, make sure the code is already following that style and people will follow by example.

[Kenneth Russell]

Comment on attachment 128779 [details]
Patch

Looks good. r=me

[Kenneth Russell]

(In reply to comment #4)
> (From update of attachment 128779 [details])
> added constant.
> 
> Just fyi though, It's frustrating to be held to a different standard than the existing code. The reason I didn't use a constant is because the code just a few lines above is not using a constant. The #1 rule I've been taught is to be consistent and follow the style of the code being modified which is what I did.
> 
> The point is, if you want a certain style, make sure the code is already following that style and people will follow by example.

I don't mean to hold you to a different standard. I'm probably personally responsible for many style issues in that file. The issue I saw during the review was a constant replicated twice. If you're referring to the 4 that's passed to the initializer of m_videoCache, note that it is only present in that one location. If you see other cleanups that should be made please file a bug and assign it to me, and I'll clean them up.

[WebKit Review Bot]

Comment on attachment 128779 [details]
Patch

Clearing flags on attachment: 128779

Committed r108861: <http://trac.webkit.org/changeset/108861>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.