Bug 79371 - [CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
Summary: [CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 09:45 PST by Patrick R. Gansterer
Modified: 2012-02-23 11:23 PST (History)
5 users (show)

See Also:


Attachments
Patch (47.93 KB, patch)
2012-02-23 09:50 PST, Patrick R. Gansterer
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-02-23 09:45:17 PST
[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
Comment 1 Patrick R. Gansterer 2012-02-23 09:50:15 PST
Created attachment 128490 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-02-23 10:25:31 PST
Looks sane to me.
Comment 3 Daniel Bates 2012-02-23 11:00:48 PST
Comment on attachment 128490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128490&action=review

> ChangeLog:8
> +        Add a new macro to handle the inclusion of the platform specifc *.cmake files.

Nit: specifc => specific

> ChangeLog:9
> +        In the future this macro should get expanded to handle also feature specifc

I think it would read better if you change "handle also" to "also handle" or "handle".

Also, specifc => specific.
Comment 4 Patrick R. Gansterer 2012-02-23 11:23:46 PST
Committed r108648: <http://trac.webkit.org/changeset/108648>