Bug 79366 - [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
Summary: [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 08:04 PST by Mike Fenton
Modified: 2012-02-23 17:27 PST (History)
3 users (show)

See Also:

Attachments
Patch (21.18 KB, patch)
2012-02-23 08:10 PST, Mike Fenton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-02-23 08:04:32 PST 
SSIA.
Comment 1 Mike Fenton 2012-02-23 08:10:05 PST 
Created attachment 128480 [details]
Patch
Comment 2 Rob Buis 2012-02-23 08:19:16 PST 
Comment on attachment 128480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128480&action=review

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:406
> +        m_webPage->m_inputHandler->handleKeyboardInput(BlackBerry::Platform::KeyboardEvent(character, BlackBerry::Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT));

Maybe you dont need BlackBerry prefix.
Comment 3 Rob Buis 2012-02-23 08:24:59 PST 
Comment on attachment 128480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128480&action=review

Looks good, BlackBerry:: prefix cleanup can be done later.

>> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:406
>> +        m_webPage->m_inputHandler->handleKeyboardInput(BlackBerry::Platform::KeyboardEvent(character, BlackBerry::Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT));
> 
> Maybe you dont need BlackBerry prefix.

Maybe you dont need BlackBerry prefix.
Comment 4 WebKit Review Bot 2012-02-23 17:26:56 PST 
Comment on attachment 128480 [details]
Patch

Clearing flags on attachment: 128480

Committed r108702: <http://trac.webkit.org/changeset/108702>
Comment 5 WebKit Review Bot 2012-02-23 17:27:01 PST 
All reviewed patches have been landed.  Closing bug.