RESOLVED FIXED 79366
[BlackBerry] InputHandler requires cleanup of Navigation Mode handling. 
https://bugs.webkit.org/show_bug.cgi?id=79366
Summary [BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
Mike Fenton
Reported 2012-02-23 08:04:32 PST
SSIA.
Attachments
Patch (21.18 KB, patch)
2012-02-23 08:10 PST, Mike Fenton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2012-02-23 08:10:05 PST
Created attachment 128480 [details] Patch
Rob Buis
Comment 2 2012-02-23 08:19:16 PST
Comment on attachment 128480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128480&action=review > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:406 > + m_webPage->m_inputHandler->handleKeyboardInput(BlackBerry::Platform::KeyboardEvent(character, BlackBerry::Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT)); Maybe you dont need BlackBerry prefix.
Rob Buis
Comment 3 2012-02-23 08:24:59 PST
Comment on attachment 128480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128480&action=review Looks good, BlackBerry:: prefix cleanup can be done later. >> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:406 >> + m_webPage->m_inputHandler->handleKeyboardInput(BlackBerry::Platform::KeyboardEvent(character, BlackBerry::Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT)); > > Maybe you dont need BlackBerry prefix. Maybe you dont need BlackBerry prefix.
WebKit Review Bot
Comment 4 2012-02-23 17:26:56 PST
Comment on attachment 128480 [details] Patch Clearing flags on attachment: 128480 Committed r108702: <http://trac.webkit.org/changeset/108702>
WebKit Review Bot
Comment 5 2012-02-23 17:27:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.