Bug 79357 – Support [Supplemental] on static methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

[Supplemental] on static methods does not work in CodeGeneratorJS.pm and CodeGeneratorV8.pm due to mis-ordered if-elsif statements. We should fix it.

[Kentaro Hara]

Created attachment 128453 [details]
Patch

[Kentaro Hara]

This fix is needed for making DOMURLMediaStream.idl.

[Adam Barth]

Comment on attachment 128453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128453&action=review

> Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:155
> +static v8::Handle<v8::Value> supplementalMethod4Callback(const v8::Arguments& args)
> +{
> +    INC_STATS("DOM.TestInterface.supplementalMethod4");
> +    TestSupplemental::supplementalMethod4(imp);
> +    return v8::Handle<v8::Value>();
> +}

How does this build?  There's no imp declared in this function.

[Kentaro Hara]

Created attachment 128601 [details]
patch for landing

[Kentaro Hara]

Comment on attachment 128601 [details]
patch for landing

> How does this build?  There's no imp declared in this function.

Fixed it. Thanks.

The run-bindings-tests results for ObjC, GObject and CPP are wrong, but it is OK since they do not yet support static methods.

[WebKit Review Bot]

Comment on attachment 128601 [details]
patch for landing

Clearing flags on attachment: 128601

Committed r108757: <http://trac.webkit.org/changeset/108757>