Bug 79357 - Support [Supplemental] on static methods
Summary: Support [Supplemental] on static methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 04:04 PST by Kentaro Hara
Modified: 2012-02-24 01:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (15.01 KB, patch)
2012-02-23 04:08 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for landing (15.12 KB, patch)
2012-02-23 16:41 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-23 04:04:48 PST
[Supplemental] on static methods does not work in CodeGeneratorJS.pm and CodeGeneratorV8.pm due to mis-ordered if-elsif statements. We should fix it.
Comment 1 Kentaro Hara 2012-02-23 04:08:45 PST
Created attachment 128453 [details]
Patch
Comment 2 Kentaro Hara 2012-02-23 04:10:58 PST
This fix is needed for making DOMURLMediaStream.idl.
Comment 3 Adam Barth 2012-02-23 10:28:54 PST
Comment on attachment 128453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128453&action=review

> Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:155
> +static v8::Handle<v8::Value> supplementalMethod4Callback(const v8::Arguments& args)
> +{
> +    INC_STATS("DOM.TestInterface.supplementalMethod4");
> +    TestSupplemental::supplementalMethod4(imp);
> +    return v8::Handle<v8::Value>();
> +}

How does this build?  There's no imp declared in this function.
Comment 4 Kentaro Hara 2012-02-23 16:41:45 PST
Created attachment 128601 [details]
patch for landing
Comment 5 Kentaro Hara 2012-02-23 16:43:41 PST
Comment on attachment 128601 [details]
patch for landing

> How does this build?  There's no imp declared in this function.

Fixed it. Thanks.

The run-bindings-tests results for ObjC, GObject and CPP are wrong, but it is OK since they do not yet support static methods.
Comment 6 WebKit Review Bot 2012-02-24 01:55:47 PST
Comment on attachment 128601 [details]
patch for landing

Clearing flags on attachment: 128601

Committed r108757: <http://trac.webkit.org/changeset/108757>