Bug 79352 - [GTK] Wrong signal name on emission in WebKitWindowProperties.cpp
Summary: [GTK] Wrong signal name on emission in WebKitWindowProperties.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-02-23 02:25 PST by Mario Sanchez Prada
Modified: 2012-02-23 16:08 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.22 KB, patch)
2012-02-23 02:28 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-02-23 02:25:26 PST
In WebKitWindowProperties::webkitWindowPropertiesSetResizable, we currently have this:

void webkitWindowPropertiesSetResizable(WebKitWindowProperties* windowProperties, bool resizable)
{
    if (windowProperties->priv->resizable == resizable)
        return;
    windowProperties->priv->resizable = resizable;
    g_object_notify(G_OBJECT(windowProperties), "resizable-visible");
}

...which is a mistake since the signal is called 'resizable', not 'resizable-visible'
Comment 1 Carlos Garcia Campos 2012-02-23 02:28:25 PST
Right, it's a copy-paste error.
Comment 2 Mario Sanchez Prada 2012-02-23 02:28:42 PST
Created attachment 128443 [details]
Patch
Comment 3 Carlos Garcia Campos 2012-02-23 02:31:25 PST
Comment on attachment 128443 [details]
Patch

Correct
Comment 4 WebKit Review Bot 2012-02-23 16:08:06 PST
Comment on attachment 128443 [details]
Patch

Clearing flags on attachment: 128443

Committed r108694: <http://trac.webkit.org/changeset/108694>
Comment 5 WebKit Review Bot 2012-02-23 16:08:15 PST
All reviewed patches have been landed.  Closing bug.