Bug 79351 – [Shadow DOM] Make Node::showTreeForThis dump multiple shadow roots.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hayato Ito]

Make Node::showTreeForThis (and showTreeForThisAcrossFrame) dump multiple shadow roots.
The current implementation dumps only the first shadow root. Which is not useful for debugging an element which has multiple shadow roots.

[Hayato Ito]

Created attachment 128439 [details]
dump multi

[Hayato Ito]

The sample output is here:

*			DIV	0x7fffe377c080 CLASS=shadowHost
				#shadow-root	0x7fffe4221400
					#shadow-root	0x7fffe3793000
						DIV	0x7fffe3794300 CLASS=class1
							DIV	0x7fffe3794180 CLASS=class3
							SHADOW	0x7fffe3794200 CLASS=shadow
							DIV	0x7fffe3794280 CLASS=class3
					DIV	0x7fffe377c200 CLASS=class1
						DIV	0x7fffe377c100 CLASS=class2
						CONTENT	0x7fffe37a45a0 CLASS=content
						DIV	0x7fffe377c180 CLASS=class2
				DIV	0x7fffe3812880 CLASS=lightChild1
				DIV	0x7fffe377c000 CLASS=lightChild2


The younger shadowRoot is displayed as a child of olderShadowRoot, which fits my mental model.
It also matchs the relation between shadowHost and shadowRoot. A child is always rendered earlier than the parent.

[Hayato Ito]

Created attachment 128448 [details]
dump multi

[Hayato Ito]

I wrongly committed the parts of this patch with http://trac.webkit.org/changeset/108605.
Which was unintentional.

This patch includes the updated version.

[Dimitri Glazkov (Google)]

Comment on attachment 128448 [details]
dump multi

ok. Would love to have something more sophisticated in the future, like an ASCII-drawn tree stack, but this is totally fine.

[WebKit Review Bot]

Comment on attachment 128448 [details]
dump multi

Rejecting attachment 128448 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11608585

[Hayato Ito]

Let me update the ChageLog, which misses a reviewer line.

(In reply to comment #6)
> (From update of attachment 128448 [details])
> Rejecting attachment 128448 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/11608585

[Hayato Ito]

Created attachment 128634 [details]
Patch for landing

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 128634 [details]:

perf/object-keys.html bug 63769 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 128634 [details]
Patch for landing

Clearing flags on attachment: 128634

Committed r108770: <http://trac.webkit.org/changeset/108770>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.