Bug 7935 - Infinite recursion in table code when button or new text fields get display:table-row
Summary: Infinite recursion in table code when button or new text fields get display:t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-23 10:56 PST by Adele Peterson
Modified: 2006-03-23 13:55 PST (History)
2 users (show)

See Also:

Attachments
patch (520 bytes, patch)
2006-03-23 11:05 PST, Adele Peterson 		no flags Details | Formatted Diff | Diff
better patch and Changelog (1.97 KB, patch)
2006-03-23 12:01 PST, Adele Peterson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2006-03-23 10:56:24 PST 
<input type="button" style="display: table-row;" value="test">

causes infinite recursion.
Comment 1 Adele Peterson 2006-03-23 10:56:55 PST 
I'm testing a fix for this.
Comment 2 Adele Peterson 2006-03-23 11:05:49 PST 
Created attachment 7253 [details]
patch
Comment 3 Adele Peterson 2006-03-23 11:13:13 PST 
Hyatt was saying that maybe we just shouldn't allow this style to be set on form elements at all.
Comment 4 Adele Peterson 2006-03-23 11:27:43 PST 
Here's the repeating bt:

#20 0x01f91260 in WebCore::RenderBlock::addChildToFlow (this=0x1347391c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderBlock.cpp:201
#21 0x01fbce98 in WebCore::RenderFlow::addChild (this=0x1347391c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderFlow.cpp:120
#22 0x020235ac in WebCore::RenderTableRow::addChild (this=0x134737fc, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTableRow.cpp:89
#23 0x02022e68 in WebCore::RenderTableSection::addChild (this=0x134736fc, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTableSection.cpp:112
#24 0x0201b220 in WebCore::RenderTable::addChild (this=0x1347354c, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTable.cpp:185
#25 0x01fb6d3c in WebCore::RenderContainer::addChild (this=0x1347342c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderContainer.cpp:154
Comment 5 Adele Peterson 2006-03-23 12:01:31 PST 
Created attachment 7257 [details]
better patch and Changelog
Comment 6 Adele Peterson 2006-03-23 13:21:32 PST 
Comment on attachment 7257 [details]
better patch and Changelog

hyatt and i discussed a different approach for this.