Bug 79348 - [Qt] Add support for touch cancellation
Summary: [Qt] Add support for touch cancellation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 01:53 PST by Simon Hausmann
Modified: 2012-02-23 11:00 PST (History)
0 users

See Also:


Attachments
Patch (23.44 KB, patch)
2012-02-23 01:58 PST, Simon Hausmann
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-02-23 01:53:50 PST
[Qt] Add support for touch cancellation
Comment 1 Simon Hausmann 2012-02-23 01:58:54 PST
Created attachment 128438 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-02-23 02:12:05 PST
Comment on attachment 128438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128438&action=review

> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:58
> +        switch (points.at(i).state()) {
> +        case Qt::TouchPointReleased: state = PlatformTouchPoint::TouchReleased; break;
> +        case Qt::TouchPointMoved: state = PlatformTouchPoint::TouchMoved; break;
> +        case Qt::TouchPointPressed: state = PlatformTouchPoint::TouchPressed; break;
> +        case Qt::TouchPointStationary: state = PlatformTouchPoint::TouchStationary; break;

I know this is nice, but it is really proper coding style?

> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:61
> +        // Qt does not have a TouchCancelled point state, so if we receive a touch cancel event,

per point you mean?
Comment 3 Simon Hausmann 2012-02-23 02:30:22 PST
Comment on attachment 128438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128438&action=review

>> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:58
>> +        case Qt::TouchPointStationary: state = PlatformTouchPoint::TouchStationary; break;
> 
> I know this is nice, but it is really proper coding style?

Heh, it's cut & paste. I'll re-format it when landing.

>> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:61
>> +        // Qt does not have a TouchCancelled point state, so if we receive a touch cancel event,
> 
> per point you mean?

I'll rephase it to this when landing: "Qt does not have a Qt::TouchPointCancelled state, ..."
Comment 4 Simon Hausmann 2012-02-23 11:00:03 PST
Committed r108643: <http://trac.webkit.org/changeset/108643>