Bug 79348 – [Qt] Add support for touch cancellation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Add support for touch cancellation

[Simon Hausmann]

Created attachment 128438 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 128438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128438&action=review

> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:58
> +        switch (points.at(i).state()) {
> +        case Qt::TouchPointReleased: state = PlatformTouchPoint::TouchReleased; break;
> +        case Qt::TouchPointMoved: state = PlatformTouchPoint::TouchMoved; break;
> +        case Qt::TouchPointPressed: state = PlatformTouchPoint::TouchPressed; break;
> +        case Qt::TouchPointStationary: state = PlatformTouchPoint::TouchStationary; break;

I know this is nice, but it is really proper coding style?

> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:61
> +        // Qt does not have a TouchCancelled point state, so if we receive a touch cancel event,

per point you mean?

[Simon Hausmann]

Comment on attachment 128438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128438&action=review

>> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:58
>> +        case Qt::TouchPointStationary: state = PlatformTouchPoint::TouchStationary; break;
> 
> I know this is nice, but it is really proper coding style?

Heh, it's cut & paste. I'll re-format it when landing.

>> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:61
>> +        // Qt does not have a TouchCancelled point state, so if we receive a touch cancel event,
> 
> per point you mean?

I'll rephase it to this when landing: "Qt does not have a Qt::TouchPointCancelled state, ..."

[Simon Hausmann]

Committed r108643: <http://trac.webkit.org/changeset/108643>