Bug 79340 - Web Inspector: add experiment that loads stylesheets as links
Summary: Web Inspector: add experiment that loads stylesheets as links
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-02-23 00:34 PST by Pavel Feldman
Modified: 2012-06-18 08:14 PDT (History)
12 users (show)

See Also:

Patch (2.92 KB, patch)
2012-02-23 00:36 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-23 00:34:25 PST
Otherwise, we can't use persistence extensions with the front-end due to XHR optimization.
Comment 1 Pavel Feldman 2012-02-23 00:36:07 PST
Created attachment 128423 [details]
Comment 2 Timothy Hatcher 2012-02-23 06:14:19 PST
"persistence extensions"?
Comment 3 Pavel Feldman 2012-02-23 06:23:45 PST
(In reply to comment #2)
> "persistence extensions"?

This minor change is for us to be able to persist changes to inspector styles while developing inspector. Today, inspector loads stylesheets using synchronous XHRs and inject them into the document. As a result, when we debug inspector, navigation to the original resources does not work, Save As does not work, extensions that can save modified resources do not work.

This change basically introduces debugging version of the front-end that uses conservative <link> tags for styles, hence making all the machinery above functioning.
Comment 4 WebKit Review Bot 2012-02-23 09:25:54 PST
The commit-queue encountered the following flaky tests while processing attachment 128423 [details]:

perf/object-keys.html bug 63769 (author: ojan@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Review Bot 2012-02-23 09:28:16 PST
Comment on attachment 128423 [details]

Clearing flags on attachment: 128423

Committed r108634: <http://trac.webkit.org/changeset/108634>
Comment 6 WebKit Review Bot 2012-02-23 09:28:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Nikita Vasilyev 2012-06-18 07:24:40 PDT
Why not just load all stylesheets via <link>? Why load them synchronously?
Comment 8 Pavel Feldman 2012-06-18 08:14:44 PDT
(In reply to comment #7)
> Why not just load all stylesheets via <link>? Why load them synchronously?

We load them lazily in View.js. Otherwise it would flicker.