WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79340
Web Inspector: add experiment that loads stylesheets as links
https://bugs.webkit.org/show_bug.cgi?id=79340
Summary
Web Inspector: add experiment that loads stylesheets as links
Pavel Feldman
Reported
2012-02-23 00:34:25 PST
Otherwise, we can't use persistence extensions with the front-end due to XHR optimization.
Attachments
Patch
(2.92 KB, patch)
2012-02-23 00:36 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-02-23 00:36:07 PST
Created
attachment 128423
[details]
Patch
Timothy Hatcher
Comment 2
2012-02-23 06:14:19 PST
"persistence extensions"?
Pavel Feldman
Comment 3
2012-02-23 06:23:45 PST
(In reply to
comment #2
)
> "persistence extensions"?
This minor change is for us to be able to persist changes to inspector styles while developing inspector. Today, inspector loads stylesheets using synchronous XHRs and inject them into the document. As a result, when we debug inspector, navigation to the original resources does not work, Save As does not work, extensions that can save modified resources do not work. This change basically introduces debugging version of the front-end that uses conservative <link> tags for styles, hence making all the machinery above functioning.
WebKit Review Bot
Comment 4
2012-02-23 09:25:54 PST
The commit-queue encountered the following flaky tests while processing
attachment 128423
[details]
: perf/object-keys.html
bug 63769
(author:
ojan@chromium.org
) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 5
2012-02-23 09:28:16 PST
Comment on
attachment 128423
[details]
Patch Clearing flags on attachment: 128423 Committed
r108634
: <
http://trac.webkit.org/changeset/108634
>
WebKit Review Bot
Comment 6
2012-02-23 09:28:20 PST
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 7
2012-06-18 07:24:40 PDT
Why not just load all stylesheets via <link>? Why load them synchronously?
Pavel Feldman
Comment 8
2012-06-18 08:14:44 PDT
(In reply to
comment #7
)
> Why not just load all stylesheets via <link>? Why load them synchronously?
We load them lazily in View.js. Otherwise it would flicker.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug