RESOLVED FIXED Bug 79320
SpellCheckRequest needs to know the context where the spellcheck happened 
https://bugs.webkit.org/show_bug.cgi?id=79320
Summary SpellCheckRequest needs to know the context where the spellcheck happened
Hajime Morrita
Reported 2012-02-22 20:19:10 PST
To save IPC requests, SpellCheckRequest can have a field which tells the client where the spellchecking is happening. For example, if a series of spellcheckings is triggered by key typing, the client can refer such hit to reuse the recent result.
Attachments
WIP (10.56 KB, patch)
2012-02-22 20:59 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (23.59 KB, patch)
2012-02-22 21:20 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (25.71 KB, patch)
2012-02-22 21:21 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
WIP (30.41 KB, patch)
2012-02-22 22:03 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (36.09 KB, patch)
2012-02-22 22:18 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (30.52 KB, patch)
2012-02-22 23:40 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (30.55 KB, patch)
2012-02-23 00:00 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (30.56 KB, patch)
2012-02-23 00:08 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (30.65 KB, patch)
2012-02-23 00:18 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (30.66 KB, patch)
2012-02-23 01:22 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (33.65 KB, patch)
2012-02-23 18:26 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (33.66 KB, patch)
2012-02-23 21:00 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-22 20:59:40 PST
Created attachment 128383 [details] WIP
Philippe Normand
Comment 2 2012-02-22 21:04:00 PST
Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11600107
WebKit Review Bot
Comment 3 2012-02-22 21:10:18 PST
Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11603093
Early Warning System Bot
Comment 4 2012-02-22 21:18:23 PST
Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11602095
Shinya Kawanaka
Comment 5 2012-02-22 21:20:10 PST
Created attachment 128387 [details] WIP
Shinya Kawanaka
Comment 6 2012-02-22 21:21:53 PST
Created attachment 128388 [details] WIP
Shinya Kawanaka
Comment 7 2012-02-22 22:03:54 PST
Created attachment 128391 [details] WIP
Shinya Kawanaka
Comment 8 2012-02-22 22:18:56 PST
Created attachment 128396 [details] Patch
Philippe Normand
Comment 9 2012-02-22 23:10:50 PST
Comment on attachment 128396 [details] Patch Attachment 128396 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11610106
Shinya Kawanaka
Comment 10 2012-02-22 23:40:09 PST
Created attachment 128410 [details] Patch
Philippe Normand
Comment 11 2012-02-22 23:44:41 PST
Comment on attachment 128410 [details] Patch Attachment 128410 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11610126
Shinya Kawanaka
Comment 12 2012-02-23 00:00:43 PST
Created attachment 128415 [details] Patch
Philippe Normand
Comment 13 2012-02-23 00:05:09 PST
Comment on attachment 128415 [details] Patch Attachment 128415 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11602131
Shinya Kawanaka
Comment 14 2012-02-23 00:08:33 PST
Created attachment 128417 [details] Patch
Shinya Kawanaka
Comment 15 2012-02-23 00:18:34 PST
Created attachment 128418 [details] Patch
Hajime Morrita
Comment 16 2012-02-23 00:22:29 PST
Comment on attachment 128418 [details] Patch Let me see the green bots.
WebKit Review Bot
Comment 17 2012-02-23 01:03:51 PST
Comment on attachment 128418 [details] Patch Attachment 128418 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11600191 New failing tests: editing/spelling/spellcheck-async.html editing/spelling/spellcheck-async-mutation.html editing/spelling/spelling-marker-description.html editing/spelling/grammar-paste.html editing/spelling/spellcheck-paste.html editing/spelling/spellcheck-sequencenum.html editing/spelling/spellcheck-queue.html
Shinya Kawanaka
Comment 18 2012-02-23 01:22:36 PST
Created attachment 128430 [details] Patch
Shinya Kawanaka
Comment 19 2012-02-23 01:24:04 PST
(In reply to comment #17) > (From update of attachment 128418 [details]) > Attachment 128418 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11600191 > > New failing tests: > editing/spelling/spellcheck-async.html > editing/spelling/spellcheck-async-mutation.html > editing/spelling/spelling-marker-description.html > editing/spelling/grammar-paste.html > editing/spelling/spellcheck-paste.html > editing/spelling/spellcheck-sequencenum.html > editing/spelling/spellcheck-queue.html Ah, I've touched PassRefPtr which became null... Boo
Gyuyoung Kim
Comment 20 2012-02-23 07:47:08 PST
Comment on attachment 128430 [details] Patch Attachment 128430 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11600311
Shinya Kawanaka
Comment 21 2012-02-23 18:26:24 PST
Created attachment 128629 [details] Patch
Shinya Kawanaka
Comment 22 2012-02-23 20:12:51 PST
mac bot seems drunk...
Shinya Kawanaka
Comment 23 2012-02-23 21:00:04 PST
Created attachment 128643 [details] Patch
WebKit Review Bot
Comment 24 2012-02-24 04:32:09 PST
Comment on attachment 128643 [details] Patch Clearing flags on attachment: 128643 Committed r108772: <http://trac.webkit.org/changeset/108772>
WebKit Review Bot
Comment 25 2012-02-24 04:32:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.