Bug 79315 - Add pixelSnapped methods to FractionalLayoutRect
Summary: Add pixelSnapped methods to FractionalLayoutRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-02-22 18:10 PST by Emil A Eklund
Modified: 2012-03-06 11:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2012-02-22 18:14 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-22 18:10:13 PST 
This will make it easier to get the pixel snapped bottom/right edges as well as the size.
Comment 1 Emil A Eklund 2012-02-22 18:14:32 PST 
Created attachment 128357 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-22 19:08:46 PST 
Comment on attachment 128357 [details]
Patch

Odd.  Why not just use rect.pixelSnapped().width(), etc?
Comment 3 Emil A Eklund 2012-02-22 19:13:10 PST 
(In reply to comment #2)
> (From update of attachment 128357 [details])
> Odd.  Why not just use rect.pixelSnapped().width(), etc?

That would be pixelSnappedIntRect(rect).width(). The advantage of these methods is that it only computed the values that are needed. Might not be worth worrying about though.
Comment 4 Levi Weintraub 2012-03-06 11:13:14 PST 
These were added in http://trac.webkit.org/changeset/109835.
Comment 5 Levi Weintraub 2012-03-06 11:13:42 PST 
Comment on attachment 128357 [details]
Patch

Clearing flags.