Bug 79310 – DFG OSR exit value profiling should have graceful handling of local variables and arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 128345 [details]
work in progress

Work in progress.  Backing up.

[Filip Pizlo]

Created attachment 128385 [details]
the patch

[Filip Pizlo]

Created attachment 128386 [details]
the patch

Updated the ChangeLog.

[Filip Pizlo]

Mac build results seem to be because some of my template foo requires some compiler love.  I'll fiddle with it.

[Early Warning System Bot]

Comment on attachment 128386 [details]
the patch

Attachment 128386 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11576125

[Filip Pizlo]

Created attachment 128405 [details]
the patch

Attempting to fix build.

[Filip Pizlo]

Created attachment 128411 [details]
the patch

More build fixing.

[Gavin Barraclough]

Comment on attachment 128411 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128411&action=review

> Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:162
> +    OwnPtr<SegmentedVector<LazyOperandValueProfile, 8> > m_data;

typedef for SegmentedVector<LazyOperandValueProfile, 8> wouldn't hurt.

> Source/JavaScriptCore/dfg/DFGNode.h:488
> +    

Please revert before landing.

[Filip Pizlo]

(In reply to comment #8)
> (From update of attachment 128411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128411&action=review
> 
> > Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:162
> > +    OwnPtr<SegmentedVector<LazyOperandValueProfile, 8> > m_data;
> 
> typedef for SegmentedVector<LazyOperandValueProfile, 8> wouldn't hurt.

Good point!

> 
> > Source/JavaScriptCore/dfg/DFGNode.h:488
> > +    
> 
> Please revert before landing.

Will do.

Thanks!

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/108677

[Filip Pizlo]

<rdar://problem/10923454>