RESOLVED FIXED 7931
Escaped elements within a textarea block can cause the textarea box to be closed prematurely 
https://bugs.webkit.org/show_bug.cgi?id=7931
Summary Escaped elements within a textarea block can cause the textarea box to be clo...
Sean Dawson
Reported 2006-03-23 08:47:31 PST
Consider the following html document: <html> <head></head> <body> <textarea> &lt;/textarea> this text should still be in the textarea box!! </textarea> </body> </html> The escaped /textarea tag in the box should not close the textarea block, but that is indeed what happens. Many web development frameworks only escape the left angle bracket, and thus this is an unavoidable problem.
Attachments
test case (130 bytes, text/html)
2006-03-23 09:30 PST, Alexey Proskuryakov 		no flags
Details
Patch v1 (16.72 KB, patch)
2008-05-27 17:53 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-03-23 09:30:47 PST
Created attachment 7250 [details] test case Same test case as an attachment.
2vanger+bugs.webkit.org
Comment 2 2008-05-20 02:25:54 PDT
also is reproducable on Safari 3.1.1 for Windows
David Kilzer (:ddkilzer)
Comment 3 2008-05-20 11:18:12 PDT
Works as expected with Firefox 2.0.0.x.
David Kilzer (:ddkilzer)
Comment 4 2008-05-27 17:53:08 PDT
Created attachment 21377 [details] Patch v1 Proposed fix.
Darin Adler
Comment 5 2008-05-29 13:25:38 PDT
Comment on attachment 21377 [details] Patch v1 Looks good, r=me We should double check if this has performance impact.
Darin Adler
Comment 6 2008-06-08 13:48:34 PDT
Comment on attachment 21377 [details] Patch v1 We tested, and this seems to have a slight but measurable performance impact on page loading. We're considering how to tweak the patch to make it faster. It may be as simple as putting the new case *after* the tagMatch instead of before. Dave, maybe we should clear the review flag so this doesn't show up in the "patches that need to be committed" list.
David Kilzer (:ddkilzer)
Comment 7 2008-06-08 13:51:22 PDT
Comment on attachment 21377 [details] Patch v1 Clearing darin's r+ flag per Comment #6.
Stephanie Lewis
Comment 8 2008-06-20 21:02:06 PDT
No more performance problems
David Kilzer (:ddkilzer)
Comment 9 2008-06-21 16:47:06 PDT
Committed revision 34722. Swapped lines per Darin in Comment #6 to fix performance issue per Comment #8.
Note You need to log in before you can comment on or make changes to this bug.