Bug 79307 – Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

Once it's ready, we should remove this tentative flag.

[Shinya Kawanaka]

It's time to remove this flag.

[Shinya Kawanaka]

Created attachment 132268 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 132268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review

Weee!!!

> LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60
> +var youngerShadowRoot = new WebKitShadowRoot(shadowHost);

Will this break the ports with shadow dom disabled?

[Shinya Kawanaka]

(In reply to comment #3)
> (From update of attachment 132268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review
> 
> Weee!!!
> 
> > LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60
> > +var youngerShadowRoot = new WebKitShadowRoot(shadowHost);
> 
> Will this break the ports with shadow dom disabled?

It should not...

[Shinya Kawanaka]

Created attachment 132535 [details]
Patch Candidate for landing

[Shinya Kawanaka]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 132268 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review
> > 
> > Weee!!!
> > 
> > > LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60
> > > +var youngerShadowRoot = new WebKitShadowRoot(shadowHost);
> > 
> > Will this break the ports with shadow dom disabled?
> 
> It should not...

shadow-root-js-api.html is in Skipped list in all ports except chromium now, so it should be OK.

[Shinya Kawanaka]

Committed r111155: <http://trac.webkit.org/changeset/111155>