RESOLVED FIXED 79303
[Supplemental] should support constants 
https://bugs.webkit.org/show_bug.cgi?id=79303
Summary [Supplemental] should support constants
Kentaro Hara
Reported 2012-02-22 16:47:37 PST
Given that we have interface [Supplemental=Y] X { constant int A = 123; } then the code generator should generate X::A to refer to the constant. However, the current code generator generates Y::A instead.
Attachments
Patch (7.87 KB, patch)
2012-02-22 16:54 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (9.44 KB, patch)
2012-02-22 17:03 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-22 16:54:51 PST
Created attachment 128335 [details] Patch
Adam Barth
Comment 2 2012-02-22 16:57:03 PST
Comment on attachment 128335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128335&action=review > Source/WebCore/bindings/scripts/CodeGenerator.pm:631 > + push(@checks, "COMPILE_ASSERT($value == " . $constant->extendedAttributes->{"ImplementedBy"} . "::$name, ${interfaceName}Enum${name}IsWrongUseDoNotCheckConstants);\n"); Do we need to make sure the header is included in the CPP file?
Kentaro Hara
Comment 3 2012-02-22 17:03:24 PST
Created attachment 128338 [details] patch for landing
Kentaro Hara
Comment 4 2012-02-22 17:04:16 PST
(In reply to comment #2) > Do we need to make sure the header is included in the CPP file? Fixed it and committed. Thanks!
WebKit Review Bot
Comment 5 2012-02-22 20:23:50 PST
Comment on attachment 128338 [details] patch for landing Clearing flags on attachment: 128338 Committed r108603: <http://trac.webkit.org/changeset/108603>
Note You need to log in before you can comment on or make changes to this bug.