[chromium] Move WebGraphicsContext3D header into the Platform directory
Created attachment 128329 [details] Patch
Created attachment 128783 [details] Patch
$ git diff master:Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h Source/Platform/chromium/public/WebGraphicsContext3D.h diff --git a/Source/Platform/chromium/public/WebGraphicsContext3D.h b/Source/Platform/chromium/public/WebGraphicsContext3D.h index 3b21164..2f804d5 100644 --- a/Source/Platform/chromium/public/WebGraphicsContext3D.h +++ b/Source/Platform/chromium/public/WebGraphicsContext3D.h @@ -136,7 +136,7 @@ public: }; // This destructor needs to be public so that using classes can destroy instances if initialization fails. - virtual ~WebGraphicsContext3D() {} + virtual ~WebGraphicsContext3D() { } // Makes the OpenGL context current on the current thread. Returns true on // success. @@ -378,7 +378,7 @@ public: virtual void deleteShader(WebGLId) = 0; virtual void deleteTexture(WebGLId) = 0; - virtual void setContextLostCallback(WebGraphicsContextLostCallback* callback) {} + virtual void setContextLostCallback(WebGraphicsContextLostCallback* callback) { } virtual void setErrorMessageCallback(WebGraphicsErrorMessageCallback* callback) { } // GL_ARB_robustness // $ git diff master:Source/WebKit/chromium/public/platform/WebNonCopyable.h Source/Platform/chromium/public/WebNonCopyable.h $
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Attachment 128783 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/Platform/chromium/public/WebGraphicsContext3D.h:195: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebGraphicsContext3D.h:230: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebGraphicsContext3D.h:231: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebGraphicsContext3D.h:342: The parameter name "w" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebGraphicsContext3D.h:344: The parameter name "w" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebGraphicsContext3D.h:359: The parameter name "w" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r108848: <http://trac.webkit.org/changeset/108848>