Bug 79300 - Add Chromium gpu_tests to the flakiness dashboard
Summary: Add Chromium gpu_tests to the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 16:34 PST by Dave Tu
Modified: 2012-02-23 17:31 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2012-02-22 16:37 PST, Dave Tu 		no flags Details | Formatted Diff | Diff
Patch (5.99 KB, patch)
2012-02-22 17:05 PST, Dave Tu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Tu 2012-02-22 16:34:27 PST 
Add Chromium gpu_tests to the flakiness dashboard.
Comment 1 Dave Tu 2012-02-22 16:37:26 PST 
Created attachment 128330 [details]
Patch
Comment 2 Ojan Vafai 2012-02-22 16:56:59 PST 
Comment on attachment 128330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128330&action=review

For future reference, you need to mark a patch as r? to mark it as ready for review. If you use "webkit-patch upload" it will automatically create the bug, generate the ChangeLog entry for you and upload it marked for review.

Also, if you mark it as cq? then that indicates to the reviewer that you'd like them to add it to the commit-queue once they approve the patch.

R- just for the sorting issue.

> ChangeLog:9
> +        * ../../builders.js:
> +        * ../../dashboard_base.js:

These paths aren't right. Did you create this ChangeLog entry using prepare-ChangeLog?

> Tools/TestResultServer/static-dashboards/builders.js:53
> +    'Chromium': '@DEPS - chromium.org',
> +    'ChromiumChromiumOS': '@DEPS CrOS - chromium.org',
> +    'ChromiumWebkit': '@ToT - chromium.org',
> +    'ChromiumGPU': '@DEPS - chromium.org',

Nit: can you sort these alphabetically?
Comment 3 Dave Tu 2012-02-22 17:05:58 PST 
Created attachment 128340 [details]
Patch
Comment 4 Dave Tu 2012-02-22 17:08:51 PST 
Thanks for the info. Sorry, I used prepare-ChangeLog and just assumed the paths were correct without checking them.
Comment 5 Ojan Vafai 2012-02-23 13:31:39 PST 
(In reply to comment #4)
> Thanks for the info. Sorry, I used prepare-ChangeLog and just assumed the paths were correct without checking them.

Hm...that's a bug in prepare-ChangeLog then. Not your fault. :(
Comment 6 Dave Tu 2012-02-23 15:59:31 PST 
Is there anything else I need to do to make the dashboard use the updated files?
Comment 7 WebKit Review Bot 2012-02-23 16:18:11 PST 
Comment on attachment 128340 [details]
Patch

Clearing flags on attachment: 128340

Committed r108695: <http://trac.webkit.org/changeset/108695>
Comment 8 WebKit Review Bot 2012-02-23 16:18:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Ojan Vafai 2012-02-23 16:54:58 PST 
(In reply to comment #6)
> Is there anything else I need to do to make the dashboard use the updated files?

Someone needs to push the new server to appengine. I won't get around to it today, but hopefully tomorrow. Also, happy to give anyone access to the server and they can push the update. :)
Comment 10 Dave Tu 2012-02-23 17:31:25 PST 
(In reply to comment #9)
> (In reply to comment #6)
> > Is there anything else I need to do to make the dashboard use the updated files?
> 
> Someone needs to push the new server to appengine. I won't get around to it today, but hopefully tomorrow. Also, happy to give anyone access to the server and they can push the update. :)

Sure, I'd be glad to, if there's instructions on how to do it.