Bug 79298 - [WebSocket] Remove zlib.h from WebSocketDeflater.h
Summary: [WebSocket] Remove zlib.h from WebSocketDeflater.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
Depends on:
Reported: 2012-02-22 16:19 PST by Kenichi Ishibashi
Modified: 2012-02-22 19:44 PST (History)
4 users (show)

See Also:

Patch (9.14 KB, patch)
2012-02-22 16:27 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-02-22 16:19:04 PST
Including zlib.h in header files introduced a bunch of zlib dependency and caused build failure unexpectedly (http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/20781). We should put zlib.h in .cpp files rather than .h files.
Comment 1 Kenichi Ishibashi 2012-02-22 16:27:03 PST
Created attachment 128326 [details]
Comment 2 Kenichi Ishibashi 2012-02-22 16:29:01 PST
Hi Kent-san,

Could you take a look? This change is needed to avoid adding a bunch of zlib dependency to GYP files.
Comment 3 Kent Tamura 2012-02-22 17:12:44 PST
Comment on attachment 128326 [details]

Looks ok.
Comment 4 Kenichi Ishibashi 2012-02-22 17:14:37 PST
Comment on attachment 128326 [details]

Thank you!
Comment 5 WebKit Review Bot 2012-02-22 19:44:34 PST
Comment on attachment 128326 [details]

Clearing flags on attachment: 128326

Committed r108600: <http://trac.webkit.org/changeset/108600>
Comment 6 WebKit Review Bot 2012-02-22 19:44:39 PST
All reviewed patches have been landed.  Closing bug.