Bug 79277 - new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
Summary: new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.7
: P2 Normal
Assignee: Daniel Bates
Depends on:
Reported: 2012-02-22 14:02 PST by Daniel Bates
Modified: 2012-02-22 15:23 PST (History)
2 users (show)

See Also:

Patch (2.85 KB, patch)
2012-02-22 14:06 PST, Daniel Bates
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2012-02-22 14:02:12 PST
I may have an instance of Safari running (either for reference or debugging) when I run new-run-webkit-tests. Currently new-run-webkit-tests launches Safari, with state restoration on OS 10.7, to show its results. It's annoying when Safari is launched with state restoration because it restores the last saved state of open windows and tabs. Safari also tends to become less responsive while it restores many windows and tabs and hence this restoration can slow down the interpretation of results. I propose that new-run-webkit-tests run the run-safari script passing the no-saved-state command line argument to disable state restoration for the session.
Comment 1 Daniel Bates 2012-02-22 14:06:25 PST
Created attachment 128285 [details]
Comment 2 Adam Barth 2012-02-22 15:19:00 PST
Comment on attachment 128285 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=128285&action=review

Oh thank you!

> Tools/ChangeLog:16
> +2012-02-22  Daniel Bates  <dbates@webkit.org>

Looks like you've got an extra changelog in here.
Comment 3 Daniel Bates 2012-02-22 15:23:26 PST
Committed r108560: <http://trac.webkit.org/changeset/108560>